Page MenuHomePhabricator
Create Task
Maniphest T172190

Add labels to form representation and language fields
Closed, ResolvedPublic
Actions

Description

Currently it is not clear what fields correspond to.
There should be labels over each the fields.
Labels should say, respectively, "Representation" and "Language"

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+1 -0Add some space between Form representation and language code fields
mediawiki/extensions/WikibaseLexememaster+20 -3Add labels to fields of the form representation widget
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Aug 1 2017, 2:36 PM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 1 2017, 2:36 PM
WMDE-leszek triaged this task as High priority.Aug 1 2017, 2:36 PM
WMDE-leszek claimed this task.Aug 1 2017, 3:35 PM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek moved this task from Backlog to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a subscriber: gerritbot.Aug 1 2017, 4:04 PM

Change 369410 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Add labels to fields of the form representation widget

https://gerrit.wikimedia.org/r/369410

gerritbot added a project: Patch-For-Review.Aug 1 2017, 4:04 PM
WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Aug 1 2017, 4:04 PM
WMDE-leszek mentioned this in rEWLE9d7efbe2d2c4: Add labels to fields of the form representation widget.Aug 1 2017, 4:07 PM
WMDE-leszek mentioned this in rEWLE1156db757df5: Add labels to fields of the form representation widget.
WMDE-leszek mentioned this in rEWLEfbbb36f3e750: Add labels to fields of the form representation widget.Aug 1 2017, 4:12 PM
• Aleksey_WMDE mentioned this in rEWLEc87c517f45b8: Add labels to fields of the form representation widget.Aug 1 2017, 4:21 PM
gerritbot added a comment.Aug 1 2017, 4:30 PM

Change 369410 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add labels to fields of the form representation widget

https://gerrit.wikimedia.org/r/369410

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Aug 1 2017, 4:31 PM
Lydia_Pintscher added a parent task: T165588: tasks for lexicographical data support until Wikimania 2017.Aug 1 2017, 7:11 PM
James_Budday added a comment.Aug 2 2017, 10:25 AM

I would add a little bit of space to show the separation and make it visually clearer.

Frame (3).png (206×323 px, 4 KB)

gerritbot added a comment.Aug 2 2017, 11:30 AM

Change 369635 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Add some space between Form representation and language code fields

https://gerrit.wikimedia.org/r/369635

WMDE-leszek moved this task from Done to Review on the Wikidata-Former-Sprint-Board board.Aug 2 2017, 11:31 AM
WMDE-leszek mentioned this in rEWLE998d36f6e232: Add some space between Form representation and language code fields.Aug 2 2017, 11:32 AM
gerritbot added a comment.Aug 2 2017, 12:58 PM

Change 369635 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add some space between Form representation and language code fields

https://gerrit.wikimedia.org/r/369635

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Aug 2 2017, 2:11 PM

Good point @James_Budday! Now there is some space between those two fields.

James_Budday awarded a token.Aug 2 2017, 3:19 PM
Lydia_Pintscher closed this task as Resolved.Aug 6 2017, 10:41 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL