Page MenuHomePhabricator

rebuildrecentchanges.php populates rc_source with extra quotes
Closed, ResolvedPublic

Description

After running the rebuildrecentchanges.php maintenance script, the rc_source field of the recentchanges table is populated with values of 'mw.edit', 'mw.log' or 'mw.new' (quotes included).

Those quotes shouldn't be there.

After performing an edit from the wiki itself, the new inserted row doesn't have quotes on the rc_source field:

MariaDB [xxxx]> select rc_timestamp, rc_source from recentchanges order by rc_timestamp desc limit 5;
+----------------+-----------+
| rc_timestamp   | rc_source |
+----------------+-----------+
| 20170801173326 | mw.edit   |
| 20170713124717 | 'mw.edit' |
| 20170713124717 | 'mw.log'  |
| 20170713124526 | 'mw.log'  |
| 20170713124503 | 'mw.log'  |
+----------------+-----------+
5 rows in set (0.00 sec)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2017, 5:40 PM
Ciencia_Al_Poder triaged this task as Normal priority.

Change 369443 had a related patch set uploaded (by Martineznovo; owner: Martineznovo):
[mediawiki/core@master] Fix overzealous addQuotes for rc_source field in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/369443

Umherirrender closed this task as Resolved.Aug 3 2017, 9:09 AM

Change 369443 merged by jenkins-bot:
[mediawiki/core@master] Fix overzealous addQuotes for rc_source field in rebuildrecentchanges.php

https://gerrit.wikimedia.org/r/369443