Page MenuHomePhabricator

NotificationsOverlay broken on mobile beta cluster
Closed, ResolvedPublic

Description

Replication steps:

This now blocks all merges on MobileFrontend and Minerva.

Caught by MobileFrontend's browser tests. Looks like an upstream OOui widget broke the entire Echo mobile notifications overlay.

load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=02xnfph:52 jQuery.Deferred exception: Cannot read property '0' of undefined TypeError: Cannot read property '0' of undefined
    at OoUiButtonWidget.OO.ui.mixin.AccessKeyedElement.formatTitleWithAccessKey (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…s%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:235:807)
    at OoUiButtonWidget.OO.ui.mixin.TitledElement.updateTitle (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…s%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:234:274)
    at OoUiButtonWidget.OO.ui.mixin.TitledElement.setTitledElement (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…s%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:233:828)
    at OoUiButtonWidget.OoUiMixinTitledElement (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…s%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:233:531)
    at new OoUiButtonWidget (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…s%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:236:222)
    at new NotificationsOverlay (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modu…rs%2Ctextures%7Cschema.EchoInteraction&skin=minerva&version=1yzt9nq:108:41)
    at <anonymous>:129:352
    at mightThrow (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=02xnfph:49:598)
    at process (https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=02xnfph:50:269) undefined
jQuery.Deferred.exceptionHook @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=02xnfph:52
process @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=02xnfph:50

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 1 2017, 11:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as Unbreak Now! priority.Aug 1 2017, 11:41 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptAug 1 2017, 11:41 PM
Jdlrobson renamed this task from NotificationsOverlay broken on mobile to NotificationsOverlay broken on mobile beta cluster.Aug 1 2017, 11:41 PM
Jdforrester-WMF closed this task as Resolved.Aug 1 2017, 11:51 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Fixed in https://gerrit.wikimedia.org/r/369572 and hacked into MW in https://gerrit.wikimedia.org/r/369578 which is now being merged.

Change 369578 had a related patch set uploaded (by Bartosz Dziewoński; owner: Jforrester):
[mediawiki/core@master] OOjs UI: Bring forward upstream fix for jQuery access key issue

https://gerrit.wikimedia.org/r/369578

Change 369578 merged by jenkins-bot:
[mediawiki/core@master] OOjs UI: Bring forward upstream fix for jQuery access key issue

https://gerrit.wikimedia.org/r/369578

Volker_E moved this task from Backlog to OOjs-UI-0.22.4 on the OOUI board.Sep 28 2017, 10:34 AM
Volker_E edited projects, added OOUI (OOjs-UI-0.22.4); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.