Maniphest T172237

[betalabs-regression] 'Other review tools' arrow placed too low
Closed, ResolvedPublic
Actions

Description

Compare with how previously the arrow was placed in betalabs

Note: testwiki wmf.12 displays the arrow correctly.

Details

Related Gerrit Patches:

mediawiki/core : master

RCFilters: Adjust styling of 'other review tools' button

Event Timeline

Etonkovidova created this task.Aug 2 2017, 12:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2017, 12:30 AM

This is a simple frameless button. @Volker_E looks like a regression in ooui's frameless buttons with indicators?

I'll be fixing this locally, but this is a bad sign for this specific release, it is probably not the only frameless button with an indicator (or ... is it?? it might be...)

Change 369812 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Adjust styling of 'other review tools' button

https://gerrit.wikimedia.org/r/369812

gerritbot added a project: Patch-For-Review.Aug 2 2017, 11:26 PM

Mooeypoo claimed this task.Aug 2 2017, 11:26 PM

Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 2 2017, 11:58 PM

Change 369812 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Adjust styling of 'other review tools' button

https://gerrit.wikimedia.org/r/369812

Etonkovidova closed this task as Resolved.Aug 4 2017, 9:18 PM

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.