Change 433915 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] [WIP] Grouped citations

https://gerrit.wikimedia.org/r/433915

hi @Sharvaniharan - please see below:

In https://phabricator.wikimedia.org/M224, @Sharvaniharan wrote:

@RHo changes are complete and a patch is available for review here : https://gerrit.wikimedia.org/r/#/c/433915/.
However, since the supporting page library PR is still not merged and published, you will not be able to verify it by checking out the patch and running as-is. So, just to get us started I have taken a few key screenshots here : https://drive.google.com/open?id=1RiL4-5kylhHps4-PHfFE_4zDcxt_XYLL . Please let me know if they need any design changes.

• Initial review is that there shouldn't be white gaps between the dividers and the overflowing text

Actual:	Expected:

• ideally when a single citation, the height of the bottom sheet is only the text height plus 16dp top and bottom padding, with a max height of 50% of the screen height.
• also the citation text should also not be entirely italicized (only names of any publications within the text), but think this is bug that is already filed separately.

Actual:	Expected

Also, a question:
I am using the material_theme_shadow color theme for the unselected dot indicators at the bottom, which is : light: black26, dark: base10, and black: base10. However, it looks different from the zeplin mock. It looks like whte40? which we don't have in our palette at all. However, I used that and took one screenshot: https://drive.google.com/open?id=1fNAlg4zCJMD9eN67Yl07dQyLOqDOOGwU which looks like the mock. So just wondering what it should be?

• Let's use 'Material theme Disabled/De-emphasised' (which in Light theme is Black@12%, and Dark/Black is White@20%)

Thanks! Though fyi if this is more finicky than anticipated, would prefer we put this on pause for the Jaffa release and finish the multilingual tagged items as prio.

Thanks @RHo.

@RHo let me know if it looks fine now.. The page-library changes have also been included, so you are good to go if you just build it and run! https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/+/433915/

hi @Sharvaniharan – still a couple of issues but it's close!

1. Height of sheet is still extending to the very top when there is a long citation:

In T172283#4249498, @RHo wrote:

• ideally when a single citation, the height of the bottom sheet is only the text height plus 16dp top and bottom padding, with a max height of 50% of the screen height.

Actual:	Expected:

2. Any reference with overflowing text in a group of citations 'jumps' upwards:

Actual: (open gif to see bug when swiping reference 14 to view)	Expected: reference 14 should start with space between the divider and first line of text

3. Alphabetical references are not rendered correctly in the title:
   • Actual:
     
   • Expected: Title should say Reference [d]

4. References inside of a citation pane should not be rendered as clickable links
   • Actual:
     
   • Expected: see iOS example
     

@RHo Could you please give me the article name, for the long reference?

Sure @Sharvaniharan - here are the articles used:

• Long reference – Barack Obama, Reference [12]
• Alphabetical reference with nested references – Empire State Building, reference [d] (appears after [33]

Thanks @RHo!

Change 433915 merged by jenkins-bot:
[apps/android/wikipedia@master] Grouped citations

https://gerrit.wikimedia.org/r/433915

Change 450045 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Grouped citations - Tweaks

https://gerrit.wikimedia.org/r/450045

hi @RHo

4. References inside of a citation pane should not be rendered as clickable links
   • Actual:
     
   • Expected: see iOS example
     

Would it be ok if we made the reference inside a citation pane clickable and render its related info in the pane?

In T172283#4481789, @Sharvaniharan wrote:

hi @RHo

4. References inside of a citation pane should not be rendered as clickable links
   • Actual:
     
   • Expected: see iOS example
     

Would it be ok if we made the reference inside a citation pane clickable and render its related info in the pane?

Hi @Sharvaniharan - I'm not quite sure what you mean? It appears to be doing so right now but without showing the clicked reference number, which is unexpected and undesired. Eg, clicking on [34] inside the citation pane brings up a new citation pane for [34] but it doesn't show what reference it is:

Change 450634 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix ability to click on references within references.

https://gerrit.wikimedia.org/r/450634

Change 450640 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Correctly pass link text through sub-reference click handler.

https://gerrit.wikimedia.org/r/450640

Change 450045 merged by jenkins-bot:
[apps/android/wikipedia@master] Grouped citations - Tweaks

https://gerrit.wikimedia.org/r/450045

Change 450634 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix ability to click on references within references.

https://gerrit.wikimedia.org/r/450634

Change 450640 merged by jenkins-bot:
[apps/android/wikipedia@master] Correctly pass link text through sub-reference click handler.

https://gerrit.wikimedia.org/r/450640

I think this is fixed 2.7.239-alpha-2018-08-21. Sending to Design for review.

Looks fixed on 2.7.239-alpha-2018-08-22