Page MenuHomePhabricator

Hide ORES review letter from the change list legend.
Open, Needs TriagePublic

Description

In a Gerrit conversation, Catrope noted:

One minor thing we may or may not care about: the entry for the "r" in the RC legend doesn't go away when you set $wgOresUiEnabled = false; . It's added through a config var directly in extension.json, so if we wanted to fix this we'd have to add an init callback and conditionally set it there. I considered doing that for other reasons (user may have prefs set such that "r" will never appear) but not sure if it's worth the effort.

awight replied,

@Catrope: It doesn't seem like we can rely on having BetaFeatures loaded at extension.json callback time? If not, then fixing might cause the "r" to become unstable for beta-enabled users.

This task is complete when we have discussed and found a way to hide the legend when not in use.

Event Timeline

awight created this task.Aug 2 2017, 11:27 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptAug 2 2017, 11:27 PM

@Catrope: It doesn't seem like we can rely on having BetaFeatures loaded at extension.json callback time? If not, then fixing might cause the "r" to become unstable for beta-enabled users.

Does it matter whether BetaFeatures is installed? We could at least check $wgOresUIEnabled here, right? I do agree that checking for the beta pref probably wouldn't work because I don't think the global User object is even available that early.

awight added a comment.Aug 6 2017, 5:03 PM

We can get pretty close to correct, or at least better than now. Agreed
that the UI flag is a good place to start, but I'm pretty sure we'll be
showing the "r" to some people that don't use it (since that's preferable
to having it lacking when it's in use).

awight added a comment.Nov 1 2018, 6:57 PM

This is unblocked, because the Beta flag for ORES (and $wgOresExtensionStatus) have been removed. We can implement as @Catrope described initially.

awight removed a subscriber: awight.Mar 21 2019, 4:01 PM
Halfak added a comment.Apr 2 2019, 9:46 PM

@Catrope is this still a thing?