Many of the constraint checker tests still use template-style parameters, e. g. [ 'property' => 'P2' ]. Before we can remove support for constraint templates, we’ll have to migrate those tests to use statement-style parameters. This can be done with helper methods in the ConstraintParameter trait, like the existing methods propertyParameter, propertiesParameter, rangeParameter, namespaceParameter, and formatParameter.
Changes:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lucas_Werkmeister_WMDE | T168240 WBQC test improvements | |||
| Resolved | Lucas_Werkmeister_WMDE | T171291 Remove support for constraint templates | |||
| Resolved | Lucas_Werkmeister_WMDE | T172378 Migrate tests to constraint statement parameters |
Change 362395 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add {class,relation}Parameter to ConstraintParameters
Change 369909 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve rangeParameter helper and use it in RangeCheckerTest
Change 369914 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate ConnectionChecker tests to statement parameters
Change 369917 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate OneOfChecker tests to statement parameters
Change 369946 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate MandatoryQualifiersChecker tests to constraint statements
Change 369955 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove constraint_status from API tests
Change 369946 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate MandatoryQualifiersChecker tests to statement parameters
Change 369955 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove constraint_status from API tests
Change 372162 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] WIP: migrate DelegatingConstraintCheckerTest to statement params
Change 372171 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate SpecialConstraintReportTest to statement parameters
Change 362395 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add {class,relation}Parameter to ConstraintParameters
Change 369909 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve rangeParameter helper and use it in RangeCheckerTest
Change 369914 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate ConnectionChecker tests to statement parameters
Change 369917 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate OneOfChecker tests to statement parameters
Change 372171 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate SpecialConstraintReportTest to statement parameters
Change 372162 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate DelegatingConstraintCheckerTest to statement params