Page MenuHomePhabricator
Create Task
Maniphest T172382

`MediaWikiMessageChecker::pagenameMessagesCheck` is incorrectly being applied also to translatable pages.
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.27.3 (2fd9800) 06:05, 7 July 2017
  • PHP 7.0.18-0ubuntu0.16.04.1 (apache2handler)
  • MySQL 5.7.19-0ubuntu0.16.04.1
  • Translate MLEB 2017.07 (rETRAd57a103ee650) 18:32, 26 July 2017
  • UniversalLanguageSelector 2017-07-25 (1395f1b) 18:32, 26 July 2017

Issue
When trying to translate the name of namespace "Help" via the translation interface the following error is issued and the translation get's fuzzied: "Namespace changed from the definition". See e.g. this page. This does not happen to all namespaces, such as "Category" so it is working there. See e.g. that page. It will be nice if all namespaces could be translated.

Originally reported on mediawiki.org.

Details

SubjectRepoBranchLines +/-
MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly applied to translatable pagesmediawiki/extensions/Translatemaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Aug 3 2017, 1:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2017, 1:15 PM
Nikerabbit triaged this task as Medium priority.Aug 3 2017, 1:47 PM
Nikerabbit moved this task from Backlog to translation aids on the MediaWiki-extensions-Translate board.
Nikerabbit added a project: good first task.

Removing line 151 from messagegroups/WikiPageMessageGroup.php should do it.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 3 2017, 1:47 PM
Kghbln awarded a token.Aug 3 2017, 1:55 PM
Noella94 claimed this task.Oct 8 2017, 6:46 PM
Noella94 added a comment.Oct 9 2017, 10:31 AM
In T172382#3497001, @Nikerabbit wrote:

Removing line 151 from messagegroups/WikiPageMessageGroup.php should do it.

last line in that file is line 90

Aklapper added a comment.Oct 9 2017, 12:00 PM

@Noella94: No, the file has 183 lines.

Noella94 added a comment.Oct 11 2017, 2:02 AM
In T172382#3669116, @Aklapper wrote:

@Noella94: No, the file has 183 lines.

Yeah! It was my error. I instead checked messagegroups/WikiMessageGroup.php. Thanks

gerritbot subscribed.Oct 11 2017, 1:43 PM

Change 383564 had a related patch set uploaded (by Noella94; owner: Noella94):
[mediawiki/extensions/Translate@master] MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly applied to translatable pages

https://gerrit.wikimedia.org/r/383564

gerritbot added a project: Patch-For-Review.Oct 11 2017, 1:43 PM
gerritbot added a comment.Oct 16 2017, 10:01 AM

Change 383564 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly applied to translatable pages

https://gerrit.wikimedia.org/r/383564

xSavitar closed this task as Resolved.Oct 16 2017, 10:06 AM
xSavitar subscribed.

Resolving this ticket. Thanks for the work @Noella94.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 16 2017, 11:00 AM
xSavitar added a project: Africa-Wikimedia-Developers.Nov 11 2017, 7:10 PM
xSavitar moved this task from Backlog to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL