Page MenuHomePhabricator

Metadata for Reading list sizes should use megabyte (MB) unit instead of mebibytes (MiB)
Closed, ResolvedPublic

Description

Open the app to reading lists - view the metadata indicating storage size on a reading list list-item and on the individual reading lists detail screen.

Expected:
Metadata for Reading list sizes should use megabytes (MB) as the standard unit of filesize measurement.

Actual:
List size is instead shown in mebibytes (MiB)

Event Timeline

Change 369929 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Use megabytes instead of mebibytes for reading list data usage.

https://gerrit.wikimedia.org/r/369929

Change 369929 merged by jenkins-bot:
[apps/android/wikipedia@master] Use megabytes instead of mebibytes for reading list data usage.

https://gerrit.wikimedia.org/r/369929

standard unit of filesize measurement

By "standard", did you actually mean "popular"? The most relevant standard is SI.

https://gerrit.wikimedia.org/r/#/c/369929/ is puzzling because the unit was changed without changing the value: either you used MiB to mean 10^6 bytes, which would be wrong; or you're now using MB to mean 2^20 bytes, which is against SI.

Remember there was even a class action against manufacturers about confusing units.
https://en.wikipedia.org/w/index.php?title=Gibibyte&type=revision&diff=793841009&oldid=788376774

Nemo_bis triaged this task as Medium priority.Aug 4 2017, 9:03 AM
Nemo_bis added a project: I18n.

@Nemo_bis The value was changed in the patch; refer to the change in dimens.xml.

ABorbaWMF subscribed.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1

Based on the app info it seems correct.