I would like to see all changes by default when I go to Special:RC.
The current default is: human, page edits, new pages, logs. When I remove them all, the "save filters" button disappears.
I would like to see all changes by default when I go to Special:RC.
The current default is: human, page edits, new pages, logs. When I remove them all, the "save filters" button disappears.
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/core | master | +28 -47 | RCFilters: Actually check whether defaults are empty and update state | |
mediawiki/core | master | +38 -7 | RCFilters: Allow empty saved query |
Of course I can do it by using a "no effect" filter combination or any number of highlights but I'm gaming the system.
Change 377932 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Allow empty saved query
The patch above works well but it creates a weird situation: when you save the empty state as your default filter, the "Restore default filters" button is visible even though you currently have your default filters.
Ha, good point. Fixing to what makes sense -- nothing. That is, neither 'default filters' nor 'reset' make sense here, because you already have defaults that are reset.
I'll hide both options (so, no 'reset' button will show in this case, nor a 'reset to defaults'), but @Pginer-WMF should verify this decision.
There was actually a bug in "areDefaultFiltersEmpty" that always returned null (!!) -- it's fixed in the new patchset, and fixes that problem as well.
Change 377932 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Allow empty saved query
Checked in betalabs
@Mooeypoo - it seems that 'Restore default filters' is lost entirely.
Or set up any filter(s) as your default - dismiss it, no 'Restore default filters' will be displayed.
@Pginer-WMF - your input is needed.
Are we treating 'All active filters. All contributions are shown.' state as a normal filter? It seems to me that we should differentiate between between discarding all filters and displaying 'All active filters. All contributions are shown.' as a filter.
If so
Change 378755 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Actually check whether defaults are empty and update state
Change 378755 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Actually check whether defaults are empty and update state
The usecase seems a bit of an edge case to me since the access to all filters is just one click away through the trashcan icon. The concept of saved filters may be easier to understand if there are some filters involved, but I'd expect that users would only get to this situation if they actually want to keep access to all unfiltered contributions.
If we want to support this, the proposed changes (e.g., removing the "restore default filters") make the behaviour consistent, and work as expected in the beta servers.
Thanks, @Pginer-WMF
Checked in betalabs. It seems to me that it works quite logically: