Page MenuHomePhabricator

Tool "cvrminer" loads bootstrap and jquery from cloudflare
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/cvrminer/: https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/css/bootstrap.min.css
https://tools.wmflabs.org/cvrminer/: https://cdnjs.cloudflare.com/ajax/libs/jquery/1.12.4/jquery.min.js
https://tools.wmflabs.org/cvrminer/: https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/js/bootstrap.min.js

Loading from external providers are discouraged. Please see parent tasks and J65.
In your case a direct replacement would be:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2017, 2:42 PM

Thanks for reminding me of this. I will change it to a toolforge serving.

Can you confirm that it no longer loads from third-party or should I just close the task myself?

zhuyifei1999 closed this task as Resolved.Aug 4 2017, 12:30 PM

LGTM, though in the console I see a lot of 404s.

Yes, the 404s is a known problem, that I should fix