Page MenuHomePhabricator

[BUG] Article added to a reading list whilst user is offline momentarily does not show in the list
Closed, ResolvedPublic

Description

A glitch occurs in the display of articles in a reading list when it is added when a user is offline.

Steps to reproduce

  1. Open the app to the "My lists" section (make sure you have at least one list saved with a few articles in that list)
  2. Tap to open that particular list, noting the metadata below the list title showing X of Y articles available offline
  3. Go into airplane mode
  4. Open an article that is available offline in that list
  5. Tap on a link in that article and add the article to the same reading list
  6. Tap the close icon, where you will be returned to that reading list. Check that the article has been added and can be seen in the list, also once again note the number X of Y articles available offline
  7. Tap back to return to the "My lists" screen and note the number of articles showing for that list
  8. Tap to open the list again

Expected

In step 6, the article added offline should appear in the list as well as incrementing the total number of Y articles in that list by 1.

Actual

In step 6, the article added offline does not appear in the list, and the total number of Y articles remains as it was in step 2.
Note: Step 7 shows that if the user exits out of the reading list to the reading lists page the accurate total number is shown, whilst step 8 shows the expected number of articles in the list after when after leaving and returning to the list.
See video: https://youtu.be/sHD5CyPyV_4

Occurring on

Nexus 5 (Android 6.0.1) v2.6.198-alpha-2017-08-03
but NOT on Pixel (Android 7.1.2) v2.6.198-alpha-2017-08-03

Event Timeline

Change 369936 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Refresh reading list fragment contents upon Resume.

https://gerrit.wikimedia.org/r/369936

Change 369936 merged by jenkins-bot:
[apps/android/wikipedia@master] Refresh reading list fragment contents upon Resume.

https://gerrit.wikimedia.org/r/369936

Appears to be working now. Tested on Nexus 5 (Android 6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08

ABorbaWMF subscribed.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1

Fixed