Maniphest T172433

Undefined index: rc_logid in includes/changes/RecentChange.php on line 338
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Notice: Undefined index: rc_logid in /srv/mediawiki/php-1.30.0-wmf.12/includes/changes/RecentChange.php on line 338

Related Objects

Mentioned Here: rMW51ce88abb96a: RCFilters: Add 'views' concept and a namespace view to RCFilters
rMW2a04f2dbf9dc: RCFilters: Filter duplicates when filtering for multiple tags
rMW9228cb1620e1: ChangeTags: Remove $wgRequest abuse in modifyDisplayQuery()
rMWe2bea6350c19: RCFilters: show new changes

Event Timeline

mmodell created this task.Aug 3 2017, 7:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2017, 7:24 PM

mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers.Aug 3 2017, 7:24 PM

Aklapper added a project: MediaWiki-Recent-changes.Aug 3 2017, 8:42 PM

Given all PHP files containing rc_login in MediaWiki core, only the following two have recently been modified:

mediawiki/includes/changetags/ChangeTags.php
- rMW9228cb1620e1: ChangeTags: Remove $wgRequest abuse in modifyDisplayQuery()
- rMW2a04f2dbf9dc: RCFilters: Filter duplicates when filtering for multiple tags
mediawiki/includes/changes/ChangesList.php
- rMWe2bea6350c19: RCFilters: show new changes
- rMW51ce88abb96a: RCFilters: Add 'views' concept and a namespace view to RCFilters

None of those changes deal with *saving* RecentChange objects though, adn the error comes from RecentChange::save().

Could we get a backtrace, please? It's possible this error came from an extension that generates its own RC rows, like Wikidata or Flow.

It might be wikidata, since I haven't seen more instances of this since reverting wikidata back to wmf.11.

I'll keep an eye out for this during next weeks train and hopefully I can get a stack trace. If it doesn't show up again I'll close as invalid.

mmodell removed a parent task: T170631: 1.30.0-wmf.13 deployment blockers.Aug 10 2017, 6:45 PM

matej_suchanek added a project: TestMe.Aug 27 2017, 12:42 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 27 2017, 12:42 PM

Apparently resolved as of wmf.13.

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptAug 28 2017, 9:19 AM

• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:44 PM

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM