mobile.startup/user should be passed in as a parameter to all our View code
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Aug 3 2017, 10:35 PM

Description

From code review session on 2nd August:
To make it clearer where and how the mw.user object literal or M.require( 'mobile.startup/user' ) is used inside a class, we believe it might be better to pass this parameter into Views as a parameter rather than using an M.require statement.

Developer notes

mw.user is used in MobileWebSearchLogger, TalkOverlay, EditorOverlayBase, BetaOptinPanel
The mobile.startup/user module is used in TalkOverlay.js, TalkSectionOverlay.js, Watchstar.js, WatchstarPageList.js, schemaMobileWebMainMenuClickTracking.js, EditorOverlayBase.js

The required MobileFrontend changes is illustrated in this patch:

A change will need to be made in MinervaNeue beforehand to pass the user parameter to the above classes.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+50 -39	User always passed in as an argument to classes

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
		Duplicate		None	T172455 mobile.startup/user should be passed in as a parameter to all our View code

Event Timeline

Jdlrobson created this task.Aug 3 2017, 10:35 PM

Jdlrobson moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.

I don't know so I'll ask: do we have sufficient test coverage so that that this task should be tagged easy?

In short - let's wait till we've talked about this in grooming and estimated it. We should check we are all okay with the change and understand the motivations. That will show up in a discussion. If it's a 1 or 2 and we all have consensus about the change yes we should slap the easy tag on it.

Estimations around 2-5 .. need to investigate the scale of what this change would like this.

Jdlrobson moved this task from Upcoming to Needs Prioritization on the Readers-Web-Backlog board.Aug 8 2017, 4:12 PM

Change 372077 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] User always passed in as an argument to classes

https://gerrit.wikimedia.org/r/372077

gerritbot added a project: Patch-For-Review.Aug 15 2017, 9:20 PM

Jdlrobson updated the task description. (Show Details)Aug 15 2017, 9:21 PM

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson moved this task from Needs Prioritization to Upcoming on the Readers-Web-Backlog board.

Jrbranaa added a subscriber: Jrbranaa.Aug 23 2017, 11:27 PM

Change 372077 abandoned by Jdlrobson:
User always passed in as an argument to classes

https://gerrit.wikimedia.org/r/372077

Jdlrobson added a project: User-Jdlrobson.Sep 27 2017, 8:39 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Readers-Web-Backlog board.Oct 2 2017, 6:21 PM

Jdlrobson closed this task as a duplicate of T172454: mw.template, mw.user and mw.msg should be wrapped by local methods in View.js.Oct 31 2017, 11:52 PM