Page MenuHomePhabricator
Create Task
Maniphest T172455

mobile.startup/user should be passed in as a parameter to all our View code
Closed, DuplicatePublic
Actions

Description

From code review session on 2nd August:
To make it clearer where and how the mw.user object literal or M.require( 'mobile.startup/user' ) is used inside a class, we believe it might be better to pass this parameter into Views as a parameter rather than using an M.require statement.

Developer notes

  • mw.user is used in MobileWebSearchLogger, TalkOverlay, EditorOverlayBase, BetaOptinPanel
  • The mobile.startup/user module is used in TalkOverlay.js, TalkSectionOverlay.js, Watchstar.js, WatchstarPageList.js, schemaMobileWebMainMenuClickTracking.js, EditorOverlayBase.js

The required MobileFrontend changes is illustrated in this patch:

A change will need to be made in MinervaNeue beforehand to pass the user parameter to the above classes.

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 3 2017, 10:35 PM
Jdlrobson moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.
Niedzielski added a subscriber: Niedzielski.Aug 4 2017, 1:58 AM

I don't know so I'll ask: do we have sufficient test coverage so that that this task should be tagged easy?

Jdlrobson added a comment.Aug 4 2017, 3:18 PM

In short - let's wait till we've talked about this in grooming and estimated it. We should check we are all okay with the change and understand the motivations. That will show up in a discussion. If it's a 1 or 2 and we all have consensus about the change yes we should slap the easy tag on it.

Jdlrobson updated the task description. (Show Details)Aug 8 2017, 4:11 PM

Estimations around 2-5 .. need to investigate the scale of what this change would like this.

gerritbot added a subscriber: gerritbot.Aug 15 2017, 9:20 PM

Change 372077 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] User always passed in as an argument to classes

https://gerrit.wikimedia.org/r/372077

Jdlrobson updated the task description. (Show Details)Aug 15 2017, 9:21 PM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson moved this task from Needs Prioritization to Upcoming on the Readers-Web-Backlog board.
gerritbot added a comment.Aug 28 2017, 3:42 PM

Change 372077 abandoned by Jdlrobson:
User always passed in as an argument to classes

https://gerrit.wikimedia.org/r/372077

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL