| RHo | |
| Aug 4 2017, 5:14 PM |
| F9195140: A08.png | |
| Aug 28 2017, 5:49 PM |
| F9195213: image.png | |
| Aug 28 2017, 5:49 PM |
| F9195129: A03iii - All available as standalone 'store'.png | |
| Aug 28 2017, 5:49 PM |
| F9195158: A06ii - one compilation.png | |
| Aug 28 2017, 5:49 PM |
| F9195191: image.png | |
| Aug 28 2017, 5:49 PM |
| F9195226: A09.png | |
| Aug 28 2017, 5:49 PM |
| F9195152: image.png | |
| Aug 28 2017, 5:49 PM |
| F9195186: image.png | |
| Aug 28 2017, 5:49 PM |
The placeholder name "Offline compilations" should be updated throughout the app with the new naming convention for the feature.
See some example usage in context below:
 |  |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Grand renaming: the sequel | apps/android/wikipedia | master | +42 -65 | |
| The offline Grand Renaming | apps/android/wikipedia | master | +30 -30 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Mholloway | T172546 Update the name of the "Offline compilations" feature to "Offline Library" containing article "packs" | |||
| Resolved | Dbrant | T174181 Undefined term "article pack" | |||
| Declined | None | T174974 Rephrase "Search Offline Library" |
Change 373627 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] The offline Grand Renaming
Change 373627 merged by jenkins-bot:
[apps/android/wikipedia@master] The offline Grand Renaming
@Mholloway - just to clarify, the feature is Offline Library, and the individual ZIM files are packs.
Here's some places where the renaming needs to be updated
| Screen | Expected | Actual | Notes |
|---|---|---|---|
| Offline Library card on Feed when offline |  |  | Action link should be "Manage my Offline Library". Text within the card should be updated as well. |
| List of all packs in the Offline Library |  |  | Title should be updated to Offline Library; description blurb needs to be updated as well. |
| Offline library |  |  | Change the title of the list to from "My article packs (#)" to "In my library (#)". Change the action text in the footer from "Add article pack" to "Add to my offline libary" |
| Remove dialog |  |  | Update dialog text and actions |
| Search when offline |  |  | Update text below search to "Search results from your Offline Library" |
| Toast message |  |  | Update so toast message is "You’re reading the version of this article from <name of article pack> • <date when ZIM was generated>." |
Thanks, @RHo. Is this everything? I'm aware of the distinction you describe, but you seem to have the idea that it's self-evident which of those that any given string should be referring to; that's not at all obvious to my non-designer's eye. ;)
I'll get started on these changes forthwith.
Thanks @Mholloway – I had tried to keep the Zeplin mocks updated with the name changes, but see you point that it is not obvious when looking at text strings out of context.
Change 374395 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Grand renaming: the sequel
Change 374395 merged by jenkins-bot:
[apps/android/wikipedia@master] Grand renaming: the sequel
On contractions ("You're reading...") in translated strings: @Nikerabbit mentioned on Gerrit that it's best to avoid them for reasons of consistency. (Consistency with what? Can you say more?)
In MediaWiki core and extensions contractions have been expanded for consistency.
For the mobile apps there is a mix of the two:
Unless there is a reason to go to the other direction (such as Android platform practices), cross-platform consistency can be reached by avoiding contractions.
@RHo Any objection to removing all contractions from our string resources and refraining from using them in the future?
hi @Mholloway – I've been following the Material writing style for Android which does use examples of contractions as part of being more concise and simpler, shorter phrasing. https://material.io/guidelines/style/writing.html#writing-language
My suggestion would be to move the subject to a separate task for discussion rather than changing all strings as part of this task, especially given that contractions appear in various places in both Android and iOS apps.