Change 370672 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Add better empty state to Offline Library screen.

https://gerrit.wikimedia.org/r/370672

Change 370672 merged by jenkins-bot:
[apps/android/wikipedia@master] Add better empty state to Offline Library screen.

https://gerrit.wikimedia.org/r/370672

Added updated assets to description

hi @Dbrant - can the updated illustration in the description be used? Visual style of packs were tweaked to be more in keeping with user-education and promo cards.

Also, not the empty state description text should be Roboto Regular 16/24sp as per other empty state description text.

Illustration and description text still to be updated per previous comment

In T172553#3552143, @RHo wrote:

Also, not the empty state description text should be Roboto Regular 16/24sp as per other empty state description text.

Not sure what this means: our other instances of empty-state text use 20sp for the empty title, and 16sp for the description, like they do here. Do empty-state titles elsewhere need to be 24sp?

Here is what the updated illustration looks like: (does this look correct? the download-arrow shape looks a bit too offset from the pack shapes.)

In T172553#3640842, @Dbrant wrote:

In T172553#3552143, @RHo wrote:

Also, not the empty state description text should be Roboto Regular 16/24sp as per other empty state description text.

Not sure what this means: our other instances of empty-state text use 20sp for the empty title, and 16sp for the description, like they do here. Do empty-state titles elsewhere need to be 24sp?

Yes, the part that needed to be fixed was that empty state text was showing as Roboto Bold with a tighter line-height (less than 24sp), the font size was accurate.

D'oh, I got it now, thanks. The notation of "16/24sp" is what threw me off. When building Android layouts, you can't really specify the line height in terms of sp units. Instead, it lets you specify the text size (16sp) plus a lineSpacingExtra parameter (8sp) which can add up to 24.

Yup, LGTM

In T172553#3640842, @Dbrant wrote:

Here is what the updated illustration looks like: (does this look correct? the download-arrow shape looks a bit too offset from the pack shapes.)

Change 381772 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Design tweak: Update empty state of offline library.

https://gerrit.wikimedia.org/r/381772

Change 381772 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: Update empty state of offline library.

https://gerrit.wikimedia.org/r/381772

LGTM

Tested on Nexus 4 with Android 5.1.1 and Pixel with Android 8.0.0 on Alpha App 2.6.203-alpha-2017-10-11

Looks good