Page MenuHomePhabricator

IABot Management Interface needs work on UI when reporting false positives
Closed, ResolvedPublic

Description

IABot Management Interface needs work on UI when reporting false positives:

  • submit button stays visible after clicking it
  • if a URL is already in the reported false positives, hide the submit button, does prevent " Reporting error: You need to provide at least one url to action. "
  • do not show sentences which do not apply, like " These URLs will be reported as false positives and reset in the DB later: " when no action will be taken

Event Timeline

Declining number 1. There's a reason why the button disables when clicked on.

Number 2 can be done.

Declining number 3. It's a non-critical update and time can be better spent fixing other bugs.

Declining number 1. There's a reason why the button disables when clicked on.
-> make it more clear then.

do not show sentences which do not apply, like " These URLs will be reported as false positives and reset in the DB later: " when no action will be taken
-> it makes the usability so much better, plus it won't take hours to fix.

Declining number 1. There's a reason why the button disables when clicked on.
-> make it more clear then.

do not show sentences which do not apply, like " These URLs will be reported as false positives and reset in the DB later: " when no action will be taken
-> it makes the usability so much better, plus it won't take hours to fix.

How do you propose making 1 more clear? A message pops asking the user to wait for the next page to load. The submit button is disabled to prevent multiple submissions and thus a DoS.

Please ignore 1, it works better now.

v1.2beta4 will have these improvements as well as providing the reason a URL is seen dead for already reported URLs.