Page MenuHomePhabricator

Tool "openrefine-wikidata" loads assets from bootstrapcdn and github
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/openrefine-wikidata/: https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css
https://tools.wmflabs.org/openrefine-wikidata/: https://ghbtns.com/github-btn.html?user=wetneb&repo=openrefine-wikidata&type=star&count=true
https://tools.wmflabs.org/openrefine-wikidata/: https://api.github.com/repos/wetneb/openrefine-wikidata?callback=callback

Loading from external providers are discouraged. Please see parent tasks and J65.

For bootstrap you can use https://tools-static.wmflabs.org/cdnjs/ajax/libs/twitter-bootstrap/3.3.7/css/bootstrap.min.css
I'm not sure about the github star button due to being dynamic content. You may want to setup a proxy or use an alternative static button.

Event Timeline

Restricted Application added subscribers: PokestarFan, Aklapper. · View Herald TranscriptAug 7 2017, 8:34 PM

PR merged, but change is not in live yet:

$ curl "https://tools.wmflabs.org/openrefine-wikidata/" -s|grep maxcdn
href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"

@Pintoch: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

If this task has been resolved in the meantime: Please update the task status (via Add Action...Change Status in the dropdown menu).
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

Pintoch closed this task as Resolved.Jan 3 2020, 11:42 AM

The task has been resolved.