Page MenuHomePhabricator

Tool "parliamentdiagram" loads assets from ajax.googleapis.com and github
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/parliamentdiagram/parliamentinputform.html: https://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js
https://tools.wmflabs.org/parliamentdiagram/parliamentinputform.html: https://assets-cdn.github.com/images/modules/logos_page/GitHub-Mark.png

Loading from external providers are discouraged. Please see parent tasks and J65.

For jquery a direct replacement would be https://tools-static.wmflabs.org/cdnjs/ajax/libs/jquery/1/jquery.min.js
For github logo, http://fontawesome.io/, which we have a mirror at https://tools-static.wmflabs.org/cdnjs/ajax/libs/font-awesome/, should provide the logo as a character in its font. Or you may want to simply host the image locally in your tool.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2017, 8:54 PM

OK, I'll do that in the next few days.

Slashme closed this task as Resolved.Aug 8 2017, 7:18 PM

Done!