Instead of manually checking file paths, loading and interpreting an equivset, it should just call AntiSpoof's equivalent function. The problem here is that AntiSpoof itself does a home-made reimplementation of strtr() - that needs to be fixed first. Bonus points for fixing generateEquivset.php to not generate replacement pairs with empty keys which currently requires a workaround.
Description
Description
Event Timeline
Comment Actions
Change 371204 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/AntiSpoof@master] Add normalizeString method
Comment Actions
Change 371205 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/AbuseFilter@master] Remove manual implementation of AntiSpoof::equivString
Comment Actions
Change 371204 merged by jenkins-bot:
[mediawiki/extensions/AntiSpoof@master] Remove homemade implementation of strtr
Comment Actions
Change 371205 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove manual implementation of AntiSpoof::equivString
Comment Actions
Would it be better to split off the method into a standalone library so this extension does not depend on the other only for this method (i.e. they can both depend on the standalone library)?