Enable CI Jenkins job test voting
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Aug 9 2017, 3:43 PM

Description

Add Jenkins job that gates commits on the success of npm test.
Consider removing label verify permission from Marvin members.

Details

	Subject	Repo	Branch	Lines +/-
	Chore: upgrade eslint-config-node-services to v2.2.3	marvin	master	+4 -4
	Marvin: add NPM template	integration/config	master	+11 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Jhernandez	T172195 Initial git repository setup
		Resolved		• Niedzielski	T172904 Enable CI Jenkins job test voting

Event Timeline

• Niedzielski created this task.Aug 9 2017, 3:43 PM

• Niedzielski updated the task description. (Show Details)

Change 370678 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[integration/config@master] Marvin: add NPM template

https://gerrit.wikimedia.org/r/370678

gerritbot added a project: Patch-For-Review.Aug 9 2017, 3:45 PM

• Niedzielski claimed this task.Aug 9 2017, 11:57 PM

Change 370678 merged by jenkins-bot:
[integration/config@master] Marvin: add NPM template

https://gerrit.wikimedia.org/r/370678

I have slightly amended @Niedzielski patch and deployed the job marvin-npm-node-6-jessie. The job passed fine.

Note there are some warnings emitted by npm 3.8.3

00:01:14.350 npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
00:01:14.351 npm WARN notsup Not compatible with your operating system or architecture: fsevents@1.1.2
00:01:14.351 npm WARN eslint-config-node-services@2.2.2 requires a peer of eslint@^3.12.0 but none was installed.

00:01:27.006 (node:1121) DeprecationWarning: [eslint] The 'ecmaFeatures' config file property is deprecated, and has no effect. (found in /home/jenkins/workspace/marvin-npm-node-6-jessie/node_modules/eslint-config-node-services/.eslintrc.js)

hashar edited projects, added Continuous-Integration-Config; removed Patch-For-Review.Aug 28 2017, 2:35 PM

hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.

Thanks @hashar ! We're aware of those warnings, the fsevents one is optional depending on OS, the eslint one is being fixed on eslint-config-node-services but it works fine with eslint v4 which we use, and the last one is a config warning that is a NOOP that we need to fix.

Nice! Thank you :]

00:01:27.006 (node:1121) DeprecationWarning: [eslint] The 'ecmaFeatures' config file property is deprecated, and has no effect. (found in /home/jenkins/workspace/marvin-npm-node-6-jessie/node_modules/eslint-config-node-services/.eslintrc.js)

@Pchelolo, this is super low priority but would it be possible to cut a release of eslint-config-node-services? I think the fix might be just in this merged PR waiting to be released!

@Niedzielski Done!

Change 374627 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[marvin@master] Chore: upgrade eslint-config-node-services to v2.2.3

https://gerrit.wikimedia.org/r/374627

gerritbot added a project: Patch-For-Review.Aug 29 2017, 8:12 PM