Page MenuHomePhabricator

[BUG] Extend gray to bottom of short article pages
Open, LowPublicBug

Description

Steps to reproduce

Search for a page with very little content, eg. "User:Reetssydney"

Expected
  • Extend gray to bottom of article
Actual
  • Base background color is white

Occurring on

iPhone 6S Plus (OS 10.1.1) on Wikipedia v 5.6.1 (1196)

Event Timeline

RHo created this task.Aug 9 2017, 4:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2017, 4:02 PM
JMinor triaged this task as Low priority.Aug 14 2017, 7:47 PM
JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
Mhurd added a subscriber: Mhurd.Aug 15 2017, 6:41 PM

@RHo
I take 'sticky' to mean the footer word mark would stick to the bottom of the page, which I'm guessing you didn't intend.

Presently we dynamically adjust the space beneath the work mark to allow you to scroll the last section to the top of the screen. This is because the TOC's current selection triggers based on which section is scrolled near the top of the screen. Without this there are weird TOC issues, which we fixed in a previous release.

2 options to consider which would work without re-creating the issues I mentioned and be easier to implement:

  • make the white at the bottom gray (seems to only be appearing on very short pages like your user page)
  • make the dynamic space I mentioned above be inserted above rather than below the word mark
Mhurd added a comment.Aug 15 2017, 6:43 PM

Making the white at the bottom gray is the option I would recommend for now, if that's ok.

RHo added a subscriber: cmadeo.Aug 15 2017, 6:53 PM

hi @Mhurd - both options sound reasonable to me, but @cmadeo should make the call

Mhurd added a comment.Aug 15 2017, 6:54 PM

@RHo sounds good thx!

RHo renamed this task from [BUG] Footer should be sticky to the bottom of article pages to [BUG] Footer should be sticky to the bottom of short article pages.Aug 15 2017, 6:54 PM
RHo updated the task description. (Show Details)

@Mhurd and @RHo, making the gray extend to the bottom sounds like the best solution for now. Thanks!

Ok, I'll update the title/description to reflect the change...

Mhurd renamed this task from [BUG] Footer should be sticky to the bottom of short article pages to [BUG] Extend gray to bottom of short article pages.Aug 15 2017, 10:56 PM
Mhurd claimed this task.
Mhurd updated the task description. (Show Details)
Mhurd moved this task from Blocked or Waiting to Doing on the iOS-app-v5.6.1-Goat-On-A-Plane board.
Mhurd added a comment.Aug 18 2017, 7:09 PM

Blocked on outcome of T173529

Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptMay 31 2019, 5:25 PM