Page MenuHomePhabricator
Create Task
Maniphest T172933

MediaWiki core was not passing phpcs
Closed, ResolvedPublic
Actions

Description

Autofixes from composer for phpcs errors

Also flagging that phpcs on master has errors locally but seems to have passed on CI

Details

ProjectBranchLines +/-Subject
mediawiki/tools/codesniffermaster+24 -8Change bootstrap-ci.php to match PHP CodeSniffer 3.0.0
mediawiki/coremaster+0 -1Do not use broken bootstrap in phpcs.xml
mediawiki/coremaster+22 -17Make phpcs pass
mediawiki/coremaster+4 -4Composer fix changes
Customize query in gerrit

Related Objects

Event Timeline

mepps created this task.Aug 9 2017, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2017, 6:50 PM
gerritbot added a subscriber: gerritbot.Aug 9 2017, 6:51 PM

Change 370866 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/core@master] Composer fix changes

https://gerrit.wikimedia.org/r/370866

gerritbot added a project: Patch-For-Review.Aug 9 2017, 6:51 PM
mepps updated the task description. (Show Details)Aug 9 2017, 6:59 PM
gerritbot added a comment.Aug 9 2017, 7:09 PM

Change 370866 merged by jenkins-bot:
[mediawiki/core@master] Composer fix changes

https://gerrit.wikimedia.org/r/370866

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 9 2017, 8:00 PM
Jdforrester-WMF renamed this task from phpcs does not pass locally to MediaWiki core was not passing phpcs.Aug 9 2017, 8:06 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added MediaWiki-General, MediaWiki-Codesniffer; removed Patch-For-Review.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Now fixed?

Umherirrender added subscribers: hashar, Legoktm, Umherirrender.Aug 10 2017, 10:24 PM

I would say the bypassed failures are fixed, but not the problem that there could bypass.

https://gerrit.wikimedia.org/r/#/c/362326/ shows the problem:

03:33:31 + vendor/bin/phpcs -p -s --report-full --report-checkstyle=/home/jenkins/workspace/mediawiki-core-phpcs-jessie/log/checkstyle.xml
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000001] [] 
03:33:32 Notice: Undefined variable: values in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 70
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000002] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000003] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000004] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000005] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000006] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000007] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000008] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000009] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000010] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000011] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000012] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000013] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000014] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000015] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000016] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000017] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000018] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000019] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000020] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000021] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000022] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000023] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000024] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000025] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000026] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000027] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000028] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000029] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000030] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000031] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 [Wed Aug  2 03:33:31 2017] [hphp] [1415:7f5e11784200:0:000032] [] 
03:33:32 Warning: in_array() expects parameter 2 to be an array or collection in /home/jenkins/workspace/mediawiki-core-phpcs-jessie/src/vendor/mediawiki/mediawiki-codesniffer/utils/bootstrap-ci.php on line 69
03:33:32 No files to process. Skipping run

See https://gerrit.wikimedia.org/r/#/c/358554/ and https://gerrit.wikimedia.org/r/#/c/363476/ for the bootstrap

gerritbot added a comment.Aug 11 2017, 1:12 PM

Change 371468 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Remove broken bootstrap from phpcs.xml

https://gerrit.wikimedia.org/r/371468

gerritbot added a project: Patch-For-Review.Aug 11 2017, 1:12 PM
Umherirrender mentioned this in T170159: Use phpcs.xml of core in mediawiki-core-phpcs-jessie.Aug 11 2017, 2:00 PM
gerritbot added a comment.Aug 11 2017, 2:07 PM

Change 371475 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Change bootstrap-ci.php to match PHP CodeSniffer 3.0.0

https://gerrit.wikimedia.org/r/371475

gerritbot added a comment.Aug 11 2017, 2:23 PM

Change 371485 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Make phpcs pass

https://gerrit.wikimedia.org/r/371485

gerritbot added a comment.Aug 11 2017, 3:18 PM

Change 371485 merged by jenkins-bot:
[mediawiki/core@master] Make phpcs pass

https://gerrit.wikimedia.org/r/371485

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 11 2017, 4:00 PM
Legoktm added a comment.Aug 11 2017, 4:17 PM

Aw crap :( thanks for figuring this out...

gerritbot added a comment.Aug 12 2017, 2:20 PM

Change 371468 merged by jenkins-bot:
[mediawiki/core@master] Do not use broken bootstrap in phpcs.xml

https://gerrit.wikimedia.org/r/371468

Umherirrender closed this task as Resolved.Aug 12 2017, 2:49 PM

With the remove of the bootstrap phpcs will now run for all files, so it should be save now/for the moment

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)); removed MW-1.30-release-notes.Aug 21 2017, 5:02 PM
gerritbot added a comment.Aug 22 2017, 10:33 AM

Change 371475 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Change bootstrap-ci.php to match PHP CodeSniffer 3.0.0

https://gerrit.wikimedia.org/r/371475

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL