Reproduceable on testwiki: enabling both beta features and trying to edit page source results in Uncaught TypeError: Cannot read property 'urlProtocols' of null. That corresponds to urlProtocols = new RegExp( mwConfig.urlProtocols, 'i' ), in resources/mode/mediawiki/mediawiki.js. Attempts to quickly fix the issue with https://gerrit.wikimedia.org/r/#/c/370950/ and https://gerrit.wikimedia.org/r/#/c/370954/ didn't work. There is clearly some module dependency issue, but we were not able to identify it during our deployment window.
Description
Description
Details
Details
Related Changes in Gerrit:
Related Objects
Related Objects
Event Timeline
Comment Actions
Is it possible to detach the regular editor and the new wikitext editor versions? It's really frustrating to leave folks waiting on the regular editor version, because that's what folks were asking for in the proposal. I want to keep working on the new editor version too, but I'd like to get people using this.
Comment Actions
I support this, especially in the light of T161054: Investigation: CodeMirror + New WikiText Editor performance issues.
Comment Actions
Change 371580 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/CodeMirror@master] Disable VE integration while we're fixing it
Comment Actions
Change 371724 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Separate out CodeMirror config data and add to VE mode
Comment Actions
Change 371580 abandoned by Esanders:
Disable VE integration while we're fixing it
Reason:
See I2d7969782ee9f02347f7aa0c7f0eebb2d592904d
Comment Actions
Change 371724 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Separate out CodeMirror config data and add to VE mode
Comment Actions
Found another teeny bug while testing this - NWE shows the 'Syntax Highlighting' tab in the dropdown and lets you enable it even if the user has not explicitly enabled the Beta feature. I'm not sure if this is intentional.