Page MenuHomePhabricator

Tool "translate" loads bootstrap from bootstrapcdn
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/translate/: https://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap.min.css
https://tools.wmflabs.org/translate/: https://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap-theme.min.css
https://tools.wmflabs.org/translate/: https://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/js/bootstrap.min.js

Loading from external providers are discouraged. Please see parent tasks and J65.
In your case a direct replacement would be:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2017, 11:30 PM
Dereckson reassigned this task from Dereckson to Framawiki.Mar 25 2018, 12:17 PM
Dereckson triaged this task as Normal priority.
Dereckson added a subscriber: Dereckson.

[ Assigning to code submitter. Priority as normal, as it reduces privacy issues and it's considered by the Wikimedia community as a best practice. ]

@Framawiki thanks for the change

@zhuyifei1999 Thanks for the report, it's probably better not to assign such tasks, just create them and add interested parties like maintainers as subscriber.

Why? First, because Phabricator doesn't send any special notification for assignment, so you don't gain any visibility [proof: I see this task 228 days later, and not because I'm assignee, but because there is a link in a pull request to it]. But most importantly, when you look a project workboard, generally, you've the feeling any assigned tasks is a task already handled by someone.

So here, potentially, someone else than Framawiki could have missed the task.

It's also valuable to remember any Toolforge project is an open source project and, as such, should be maintained as an open source project, and not, like a private piece of software. As such, politically, assign to the tool author, is also bad, as it .

And to be honest, I don't think I would have handled this task, because I didn't know where the repos where, and I wouldn't have been interested enough by the task to hunt them. GitHub is not at all my usual place of work, it's my usual place of mirroring repos.

So, in a nutshell, when you assign a task to someone who hasn't claim explicitly on another channel (e.g. on IRC, on another task, by mail, on a wiki message) they want to be assigned the task, you risk the task to be lost, with everybody thinking the assignee is taking care of it when in reality, nobody is acting upon. But a task unassigned is a task open for all to grab.

Dereckson closed this task as Resolved.Mar 25 2018, 2:48 PM

Code has been deployed.

First, because Phabricator doesn't send any special notification for assignment, so you don't gain any visibility

Interesting. I thought the phab related logic is that assignee is auto-subscribed. Sounds like a bug to me.

It's also valuable to remember any Toolforge project is an open source project and, as such, should be maintained as an open source project, and not, like a private piece of software. As such, politically, assign to the tool author, is also bad, as it .

Good point. At the time of the task manual mass-creation I didn't expect anyone other than tool maintainers to do the changes, because of the amount of work needed to check the source code every affected tool. @Framawiki is being very generous here ;)

And to be honest, I don't think I would have handled this task, because I didn't know where the repos where, and I wouldn't have been interested enough by the task to hunt them. GitHub is not at all my usual place of work, it's my usual place of mirroring repos.

In the related subtasks, I have used 'assignee' instead of 'subscribe' in the cases when there are only one claimed maintainer to the tool as listed in LDAP. It made sense that the only maintainer would know where the repos were.

So, in a nutshell, when you assign a task to someone who hasn't claim explicitly on another channel (e.g. on IRC, on another task, by mail, on a wiki message) they want to be assigned the task, you risk the task to be lost, with everybody thinking the assignee is taking care of it when in reality, nobody is acting upon. But a task unassigned is a task open for all to grab.

Thanks. I'll keep this in mind next time.

It made sense that the only maintainer would know where the repos were.

Would that be useful to standardise that and have a catalog of tools repositories?

Would that be useful to standardise that and have a catalog of tools repositories?

Ping @Harej