Page MenuHomePhabricator

Tool "wikidata-slicer" loads fonts from google
Open, Needs TriagePublic

Description

https://tools.wmflabs.org/wikidata-slicer/: https://fonts.googleapis.com/css?family=Lato:400,700,400italic

Loading from external providers are discouraged. Please see parent tasks and J65.
In your case a direct replacement would be https://tools-static.wmflabs.org/fontcdn/css?family=Lato:400,700,400italic

Event Timeline

Restricted Application added subscribers: PokestarFan, Aklapper. · View Herald TranscriptAug 9 2017, 11:50 PM

As you can see, the googleapis request comes from https://tools-static.wmflabs.org/cdnjs/ajax/libs/bootswatch/3.3.7/flatly/bootstrap.min.css. Unfortunately, there doesn't seem to be an easy way to avoid the request without forking or recompiling the CSS.

As you can see, the googleapis request comes from https://tools-static.wmflabs.org/cdnjs/ajax/libs/bootswatch/3.3.7/flatly/bootstrap.min.css. Unfortunately, there doesn't seem to be an easy way to avoid the request without forking or recompiling the CSS.

:(

Recompiling the Sass should not be too hard. Hosting it as part of the tool itself would cause the benefits of the cdnjs to get missed, though, as far as the theme is concerned. Or I might do without the theme entirely. Anyway I'm not placing this up for grabs as it does not make sense for anyone else to work on the Wikidata Slicer in its current state.

bd808 added a subscriber: bd808.May 21 2020, 5:39 PM

I wonder if we should try to figure out how to use https://nginx.org/en/docs/http/ngx_http_sub_module.html in the cdnjs proxy config to do some automated rewriting of things like @import url("https://fonts.googleapis.com/css?family=Lato:400,700,400italic"); to @import url("https://tools-static.wmflabs.org/fontcdn/css?family=Lato:400,700,400italic");?

Aklapper removed Ricordisamoa as the assignee of this task.Jun 19 2020, 4:13 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)