[BUG] Offline compilations card should no longer be shown on the feed once connectivity is regained
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Aug 10 2017, 2:41 PM

Description

Steps to reproduce

Pre-requisites for this test: At least one offline compilation has been downloaded

Whilst the app is open on the Explore feed, go into airplane mode and note the offline compilations card advising "You are now browsing Wikipedia in offline mode".
Navigate away from the feed, eg by opening a random article
Exit airplane mode and wait until connectivity is regained
Close the article and return to the feed (but do not pull down to refresh)

Expected

The "Offline compilations" card should no longer appear on the feed (in the same way that in step 1 the "Offline compilations" card appears and other cards are removed as soon as it is detected that connectivity was lost.)

Actual

The "Offline compilations" card remains despite connectivity being regained.

Occurring on

Pixel (Android 7.1.2) on Wikipedia v2.6.200-2017-08-09

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Trigger a feed refresh when connectivity is regained	apps/android/wikipedia	master	+16 -0

Customize query in gerrit

Event Timeline

RHo created this task.Aug 10 2017, 2:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2017, 2:41 PM

• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.Aug 16 2017, 3:32 PM

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩). · View Herald TranscriptAug 16 2017, 3:32 PM

• NHarateh_WMF edited projects, added Android-app-feature-Compilations-v1; removed Android-app-feature-Compilations.Aug 16 2017, 3:32 PM

• Mholloway edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.Aug 16 2017, 4:41 PM

• NHarateh_WMF moved this task from To Do to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 28 2017, 5:04 PM

• Mholloway claimed this task.Aug 30 2017, 3:03 PM

• Mholloway moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.

Change 374829 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Trigger a feed refresh when connectivity is regained

https://gerrit.wikimedia.org/r/374829

gerritbot added a project: Patch-For-Review.Aug 30 2017, 3:14 PM

• Mholloway moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Aug 30 2017, 3:15 PM

Change 374829 merged by jenkins-bot:
[apps/android/wikipedia@master] Trigger a feed refresh when connectivity is regained

https://gerrit.wikimedia.org/r/374829

• Mholloway moved this task from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Sep 1 2017, 2:50 PM