Page MenuHomePhabricator

Tool "wikipedia-fetch-content" loads jquery and bootstrap from code.jquery.com and bootstrapcdn
Closed, ResolvedPublic

Description

https://tools.wmflabs.org/wikipedia-fetch-content/: https://netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap.min.css
https://tools.wmflabs.org/wikipedia-fetch-content/: https://code.jquery.com/jquery-1.12.4.js
https://tools.wmflabs.org/wikipedia-fetch-content/: https://netdna.bootstrapcdn.com/bootstrap/3.0.0/js/bootstrap.min.js

Loading from external providers are discouraged. Please see parent tasks and J65.
In your case a direct replacement would be:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2017, 1:05 AM

@zhuyifei1999, thanks again for reporting this. I will go ahead and fix this once and or all :). I need to keep this link in my head: https://tools-static.wmflabs.org/cdnjs/ :D

This patch solves the issue: Patch Set 1. @zhuyifei1999, once you confirm that this tool doesn't use external resources, I can mark it as resolved. Thanks.

D3r1ck01 updated the task description. (Show Details)Aug 16 2017, 3:48 PM
D3r1ck01 added a project: Patch-For-Review.
zhuyifei1999 closed this task as Resolved.Aug 16 2017, 11:50 PM

Thanks, LGTM.

Thanks, LGTM.

Thanks @zhuyifei1999. And also, thanks for reporting this. I had no idea TL had all these external resources in one place. That's one great thing I have learned. :)