Page MenuHomePhabricator

Dashboard overlay not covering viewport
Closed, ResolvedPublic

Description

Content Translation dashboard allows starting of a new article by clicking on "New Translation" button or selecting one of suggested items from the list.

Both cases open modal dialog with gray overlay behind. Problem shows up when user scrolls down on Suggestion tab, then chooses item from the list. Below screenshot shows the issue, with red arrow pointing where overlay stops, not covering viewport. This opens possibilities for user to click on everything below, what is not desired behavior.

Another way to cause non-full-height overlay is by scrolling down on any list and clicking "New Translation" button.

Another issue is clickable elements on fixed top navigation header, that is present even when overlay covers full screen height.

Event Timeline

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptAug 11 2017, 12:22 PM

Change 371467 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix dashboard usability issues

https://gerrit.wikimedia.org/r/371467

Petar.petkovic triaged this task as Normal priority.Aug 11 2017, 1:52 PM

Change 371467 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix dashboard usability issues

https://gerrit.wikimedia.org/r/371467

Checked the fix in enwiki wmf.15.

When the New translation modal dialog will present grey overlay background where no scrolling or no selection of any of the page's functionality is possible.

Etonkovidova closed this task as Resolved.Aug 28 2017, 10:41 PM