Page MenuHomePhabricator

[BUG] Cannot remove downloaded offline compilations
Closed, ResolvedPublic

Description

Steps to reproduce

Pre-requisite: Two or more offline compilations (aka article pack) have been downloaded

  1. Open Offline compilations (aka Offline library) by selecting it from the overflow menu on the Explore feed
  2. Tap on the overflow menu on the first downloaded offline compilation, and select to "Delete" the compilation.
  3. Tap "yes" on the dialog asking for confirmation of the delete action
  4. Tap on the second offline compilation in the list to open its details screen.
  5. Tap on the "Remove" button
  6. Tap "yes" on the dialog asking for confirmation of the delete action

Expected

The user is able to delete compilations in both ways (via the overflow menu in the manage compilations list screen or the "remove" button in the specific compilation details screen)

Expected: Delete is an option in the overflow menu:
A06iv - share file option.png (1×720 px, 118 KB)
Expected: Tapping remove in the details screen brings up a confirmation dialog:
A05.png (1×720 px, 124 KB)

Actual

  • Step 2 - tapping on the overflow menu does nothing (no overflow menu is shown)
  • Step 5 - tapping on the "Remove" button does nothing

Occurring on

Nexus 5 (Android 6.0.1) - Wikipedia v2.6.201-alpha-2017-08-10

Event Timeline

Change 373316 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Implement sharing and deleting of compilations.

https://gerrit.wikimedia.org/r/373316

Change 373316 merged by jenkins-bot:
[apps/android/wikipedia@master] Implement sharing and deleting of compilations.

https://gerrit.wikimedia.org/r/373316

working on Pixel (Android 7.1.2) on Wikipedia version 2.6.201-alpha-2017-08-24

ABorbaWMF added a subscriber: ABorbaWMF.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-25

Removing is working