The [[Special:Watchlist]] page shows a legend block. Alignment of items inside this block looks a little weird.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 372084 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Fix messed up recent changes/watchlist legends
Comment Actions
Change 372085 had a related patch set uploaded (by Dereckson; owner: Isarra):
[mediawiki/skins/Timeless@wmf/1.30.0-wmf.14] Fix messed up recent changes/watchlist legends
Comment Actions
Change 372084 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Fix messed up recent changes/watchlist legends
Comment Actions
Change 372086 had a related patch set uploaded (by Dereckson; owner: Isarra):
[mediawiki/skins/Timeless@wmf/1.30.0-wmf.13] Fix messed up recent changes/watchlist legends
Comment Actions
Change 372086 merged by jenkins-bot:
[mediawiki/skins/Timeless@wmf/1.30.0-wmf.13] Fix messed up recent changes/watchlist legends
Comment Actions
Change 372085 merged by jenkins-bot:
[mediawiki/skins/Timeless@wmf/1.30.0-wmf.14] Fix messed up recent changes/watchlist legends
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-08-15T23:55:07Z] <dereckson@tin> Synchronized php-1.30.0-wmf.13/skins/Timeless/resources/screen-common.less: Fix messed up recent changes/watchlist legends (T173151) (duration: 00m 54s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-08-15T23:58:45Z] <dereckson@tin> Synchronized php-1.30.0-wmf.14/skins/Timeless/resources/screen-common.less: Fix messed up recent changes/watchlist legends (T173151) (duration: 00m 50s)
Comment Actions
This is caused by dt element sharing a style block with headers, which have: margin: 1.5em 0 0.5em. This makes their height larger than the line-height of single line dd elements following them.
If that margin was intentional, then it was probably supposed to be on the <dl> element instead. And maybe it's just a complete oversight :)
Anyway, dt's are not headers and should not be treated like such.
Comment Actions
Since @Legoktm merged my task here, I'd also like to note the abbreviations in the legend should also be in bold face.
Comment Actions
Looks like this is a specificity issue (T192560): .mw-changeslist-legend dt has the rule margin: 0 0.5em 0 0, but this is overridden by #mw-content dt having rules margin-top: 1em; and margin: 1.5em 0 0.5em;
Comment Actions
Should now be properly resolved in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/501850, which should go out next week.
(Forgot to tag this because I didn't realise this hadn't already been resolved, and thought I'd reintroduced it and then had to fix it again.)