Page MenuHomePhabricator
Create Task
Maniphest T173181

Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The current text of Visualeditor-mwlanguagevariantcontextitem-rule-code-label is Language code.

"nbsp" is hard to translate.

It would be much better to define it as non-breaking in CSS, and leave only the English text in the message, without markup.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-labelmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Aug 12 2017, 2:10 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptAug 12 2017, 2:10 PM
Esanders added a subscriber: cscott.Aug 13 2017, 6:17 PM
• Deskana triaged this task as Low priority.Aug 18 2017, 1:10 PM
• Deskana moved this task from To Triage to Freezer on the VisualEditor board.
xSavitar added a project: Africa-Wikimedia-Developers.Aug 20 2017, 1:58 PM
xSavitar moved this task from Backlog to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.
Eugene233 claimed this task.Aug 25 2017, 1:15 PM
gerritbot subscribed.Aug 25 2017, 1:36 PM

Change 373890 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[mediawiki/extensions/VisualEditor@master] Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label

https://gerrit.wikimedia.org/r/373890

gerritbot added a project: Patch-For-Review.Aug 25 2017, 1:36 PM
Eugene233 moved this task from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.Aug 25 2017, 1:44 PM
Eugene233 added a subscriber: Anomie.Aug 26 2017, 6:49 AM

@Amire80 after trying the blame I noticed one potential person was @Anomie. So @Anomie could you help us with this issue while looking that the last comment here ?

Anomie unsubscribed.Aug 28 2017, 2:40 PM
In T173181#3555248, @Eugene233 wrote:

after trying the blame I noticed one potential person was @Anomie.

You did git blame wrong. The person who added the   was @cscott in rEVEDc89a3059f84a: Context item for LanguageConverter markup.

Eugene233 added a subscriber: Anomie.Aug 29 2017, 11:22 AM

Thanks @Anomie for the clarification.

Anomie unsubscribed.Aug 29 2017, 1:35 PM
Kizule moved this task from Backlog to Doing on the good first task board.Sep 20 2017, 2:52 PM
gerritbot added a comment.Sep 20 2017, 4:20 PM

Change 373890 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove nbsp from Visualeditor-mwlanguagevariantcontextitem-rule-code-label

https://gerrit.wikimedia.org/r/373890

Kizule closed this task as Resolved.Sep 20 2017, 4:22 PM
Kizule removed a project: Patch-For-Review.
Kizule moved this task from Doing to Done on the good first task board.
Kizule subscribed.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 20 2017, 4:22 PM
xSavitar awarded a token.Sep 20 2017, 4:23 PM
xSavitar moved this task from Tasks in progress (Doing) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 20 2017, 5:00 PM
Jdforrester-WMF set the point value for this task to 1.Sep 26 2017, 3:03 PM
Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits