| • Deskana | |
| Aug 13 2017, 3:49 PM |
| F9206351: Screen Shot 2017-08-29 at 9.37.13 AM.png | |
| Aug 29 2017, 4:40 PM |
| F9174551: Screen Shot 2017-08-25 at 11.22.21 AM.png | |
| Aug 25 2017, 7:22 PM |
| F9174556: Screen Shot 2017-08-25 at 11.22.07 AM.png | |
| Aug 25 2017, 7:22 PM |
| F9061159: Screen Shot 2017-08-13 at 11.44.41.png | |
| Aug 13 2017, 3:49 PM |
I set a default edit filter and opened the filters menu. It showed the default filter I chose with an pin, which is nice. I clicked on the pin expecting it to remove it as my default, but it closed the menu rather than doing that. I think it'd be useful to add some functionality to that.
For a solution to this, please see Pau's post, below.
If you simply remove the default (rather than replace it with a different default), it will fall back to the one-by-one preferences (e.g. hide minor by default). This is undesirable, since we're going to hide the one-by-one preferences.
This particular pushpin instance was intended to be presented more like a marker than an action (T164128). Some adjustments that could help:
The icon is coming from OOUI; we'll have to have overrides, but I think it's justified in this case (just pointing out we do override in this case.)
I'll take a look on how to properly implement this.
Change 373399 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Adjust puspin 'default' icon behavior and style
Done.
- Use grey as the color. We can use Base20 (#54595D)
Can't directly change the color, so I've used opacity instead. opacity:0.5; seemed to be fairly good, but may require a little bit of adjustment later.
- Use it as a shortcut for opening the menu, where the "default" status can be adjusted from. This provides a safe path for those trying to act on the mark to access related actions.
Done.
Change 373399 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Adjust pushpin 'default' icon behavior and style
@Pginer-WMF Please take a look if all looks fine.
(1) Current wmf.15 (the big icon) - the sizes of the icons (in the menu and when it's placed at the saved menu name)
After the fix - currently in betalabs:
(2) Regarding the behavior (a rather minor point): there is a little discrepancy between clicking on the pushpin icon and on the dotdotdot menu.
Click on the pushpin button - the menu will open. Click again - the menu won't close.
Click on the dotdotdot buton - the menu will open. Click again - the menu will close.
Based on the images, a couple of adjustments are needed:
(2) Regarding the behavior (a rather minor point): there is a little discrepancy between clicking on the pushpin icon and on the dotdotdot menu.
Click on the pushpin button - the menu will open. Click again - the menu won't close.
Click on the dotdotdot buton - the menu will open. Click again - the menu will close.
That's ok, the pushpin is not intended as the main entry point to control the menu, just as a shortcut for users that may get lost trying to act on it.
Change 374434 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Target pushPin icon for size, not all icons
Change 374434 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Target pushPin icon for size, not all icons
Re-checked - it seems that @Pginer-WMF comments have been integrated:
The "..." icon should not be reduced in size. That is a regular button that should remain as it was before.
The small pushpin icon seems not to be vertically aligned, with respect to the line it occupies.
QA Recommendation: Resolve