Can't change number of results selector after you click trashcan
Closed, ResolvedPublic
Actions

Description

On production

Go to the Recent Changes page (with the New Filters beta)
Load a saved filter (I'm not positive if this is required or not)
Click the trashcan to delete all filters
Use the number of results selector to change the number of results to display

Expected result: you change the number
Actual result: the number doesn't change

Note: The above steps wmf 13 work as expected.

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Fix validation for single_option groups	mediawiki/core	wmf/1.30.0-wmf.14	+31 -26
	RCFilters: Fix validation for single_option groups	mediawiki/core	master	+31 -26

Customize query in gerrit

Related Objects

Mentioned Here: T172560: "Loss of session data" on Beta Cluster

Event Timeline

• jmatazzoni created this task.Aug 14 2017, 11:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2017, 11:46 AM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 14 2017, 11:46 AM

• jmatazzoni updated the task description. (Show Details)Aug 14 2017, 11:49 AM

Betalabs bug - quite possibly related to T172560: "Loss of session data" on Beta Cluster

Etonkovidova renamed this task from Can't change number of results selector after you click trashcan to [betalabs] Can't change number of results selector after you click trashcan.Aug 14 2017, 5:09 PM

Etonkovidova updated the task description. (Show Details)

@Etonkovidova You added "betalabs" to the title. I saw this bug on production, not beta. Does that matter?

• jmatazzoni renamed this task from [betalabs] Can't change number of results selector after you click trashcan to Can't change number of results selector after you click trashcan.Aug 16 2017, 8:37 PM

• jmatazzoni updated the task description. (Show Details)

Change 372428 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Fix validation for single_option groups

https://gerrit.wikimedia.org/r/372428

gerritbot added a project: Patch-For-Review.Aug 17 2017, 6:29 PM

Mooeypoo claimed this task.Aug 17 2017, 6:30 PM

Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 372428 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Fix validation for single_option groups

https://gerrit.wikimedia.org/r/372428

Change 372449 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@wmf/1.30.0-wmf.14] RCFilters: Fix validation for single_option groups

https://gerrit.wikimedia.org/r/372449

Change 372449 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.14] RCFilters: Fix validation for single_option groups

https://gerrit.wikimedia.org/r/372449

Mentioned in SAL (#wikimedia-operations) [2017-08-17T23:21:57Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.14/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js: SWAT: [[gerrit:372449|RCFilters: Fix validation for single_option groups]] T173303 (duration: 00m 44s)

Mooeypoo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 17 2017, 11:23 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 7:01 PM

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)); removed MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 8:02 PM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Aug 24 2017, 12:03 AM

Can't change number of results selector after you click trashcanClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Can't change number of results selector after you click trashcan
Closed, ResolvedPublic
Actions