Page MenuHomePhabricator
Create Task
Maniphest T173360

PHP Notice: Undefined index: frameCount
Closed, ResolvedPublic
Actions

Description

I receive lots of errors like this everyday on my logs:

2017-08-14 22:12:17 (...) ErrorException from line 104 of .../mediawiki-1.29.0/includes/media/GIF.php: PHP Notice: Undefined index: frameCount
#0 .../mediawiki-1.29.0/includes/media/GIF.php(104): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 .../mediawiki-1.29.0/includes/media/Bitmap.php(180): GIFHandler->isAnimatedImage(LocalWikiDexFile)
#2 .../mediawiki-1.29.0/includes/media/TransformationalImageHandler.php(246): BitmapHandler->transformImageMagick(LocalWikiDexFile, array)
#3 .../mediawiki-1.29.0/includes/filerepo/file/File.php(1141): TransformationalImageHandler->doTransform(LocalWikiDexFile, string, string, array)
#4 .../mediawiki-1.29.0/includes/filerepo/file/File.php(1104): File->generateAndSaveThumb(TempFSFile, array, integer)
#5 .../mediawiki-1.29.0/thumb.php(432): File->transform(array, integer)
#6 .../mediawiki-1.29.0/includes/poolcounter/PoolCounterWorkViaCallback.php(69): {closure}()
#7 .../mediawiki-1.29.0/includes/poolcounter/PoolCounterWork.php(123): PoolCounterWorkViaCallback->doWork()
2017-08-14 22:50:48 (...)  ErrorException from line 93 of .../mediawiki-1.29.0/includes/media/PNG.php: PHP Notice: Undefined index: frameCount
#0 .../mediawiki-1.29.0/includes/media/PNG.php(93): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 .../mediawiki-1.29.0/includes/filerepo/file/File.php(619): PNGHandler->isAnimatedImage(LocalWikiDexFile)
#2 .../mediawiki-1.29.0/includes/page/ImagePage.php(566): File->canAnimateThumbIfAppropriate()
#3 .../mediawiki-1.29.0/includes/page/ImagePage.php(150): ImagePage->openShowImage()
#4 .../mediawiki-1.29.0/includes/actions/ViewAction.php(68): ImagePage->view()
#5 .../mediawiki-1.29.0/includes/MediaWiki.php(499): ViewAction->show()
#6 .../mediawiki-1.29.0/includes/MediaWiki.php(293): MediaWiki->performAction(ImagePage, Title)
#7 .../mediawiki-1.29.0/includes/MediaWiki.php(862): MediaWiki->performRequest()
#8 .../mediawiki-1.29.0/includes/MediaWiki.php(523): MediaWiki->main()
#9 .../mediawiki-1.29.0/index.php(43): MediaWiki->run()
#10 {main}

The wiki was migrated from an old MediaWiki 1.19. Maybe the image metadata needs to be refreshed, but there should be a sanity check that metadata contains the frameCount property.

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Aug 15 2017, 8:09 AM
Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptAug 15 2017, 8:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a project: good first task.Aug 17 2017, 8:58 PM
matmarex subscribed.

What is a LocalWikiDexFile, and why are GIFHandler and PNGHandler trying to handle it? :o Perhaps you have some extension that isn't cooperating with MediaWiki right.

Regardless, adding an isset() check in GIFHandler::isAnimatedImage() and PNGHandler::isAnimatedImage() would probably be sensible anyway. I note that SvgHandler::isAnimatedImage() and WebPHandler::isAnimatedImage() both have such a check.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 17 2017, 8:58 PM
Ciencia_Al_Poder added a comment.Aug 17 2017, 9:50 PM

LocalWikiDexFile just extends LocalFile to add a cache buster to image URLs (/latest/(timestamp)/). The only relevant override is getUrlRel:

(doc comments removed)

class LocalWikiDexFile extends LocalFile {
	const VERSION = 101; // cache version

	// Copied from LocalFile to avoid self create a LocalFile class instead of a LocalWikiDexFile class
	static function newFromTitle( $title, $repo, $unused = null ) {
		return new self( $title, $repo );
	}

	// Copied from LocalFile to avoid self create a LocalFile class instead of a LocalWikiDexFile class
	static function newFromRow( $row, $repo ) {
		$title = Title::makeTitle( NS_FILE, $row->img_name );
		$file = new self( $title, $repo );
		$file->loadFromRow( $row );

		return $file;
	}

	// Copied from LocalFile to avoid self create a LocalFile class instead of a LocalWikiDexFile class
	static function newFromKey( $sha1, $repo, $timestamp = false ) {
		$dbr = $repo->getReplicaDB();

		$conds = [ 'img_sha1' => $sha1 ];
		if ( $timestamp ) {
			$conds['img_timestamp'] = $dbr->timestamp( $timestamp );
		}

		$row = $dbr->selectRow( 'image', self::selectFields(), $conds, __METHOD__ );
		if ( $row ) {
			return self::newFromRow( $row, $repo );
		} else {
			return false;
		}
	}

	function __construct( $title, $repo ) {
		$this->repoClass = 'LocalWikiDexRepo';
		parent::__construct( $title, $repo );
	}
	
	function getUrlRel() {
		return $this->getHashPath() . 'latest/' . $this->getTimestamp() . '/' . rawurlencode( $this->getName() );
	}
}
Ciencia_Al_Poder claimed this task.Oct 22 2017, 2:35 PM
Ciencia_Al_Poder closed this task as Invalid.Oct 22 2017, 5:15 PM

Aaand finally found it's not really a bug, because (without my extension) old files get metadata updated automatically when the file is accessed, and the property is there without causing those errors.

Sadly my overwrite of getUrlRel() was adding the extra stuff in the URL causing internal functions to not find the file to load the metadata. I am surprised by this, because the wiki works without problems since the first day, files and thumbnails get placed to where they belong, and such, but this was failing silently.

Ciencia_Al_Poder reopened this task as Open.Nov 4 2017, 2:45 PM
Ciencia_Al_Poder triaged this task as Low priority.

Errors are still popping in... Even if loading the file description page makes the database to reload the metadata and save it, the first time it gets loaded and converted the error gets logged.

I've finally run maintenance/refreshImageMetadata.php to avoid them. I though it would take a long time, but it was really fast.

Another thing is that it currently "fixes itself" the metadata information on page view, which is bad for T92357: Fix database master queries from HTTP GET/HEAD before active-active multi-dc. If someone fixes it, then errors will not stop from happening...

Ciencia_Al_Poder added a comment.Nov 4 2017, 2:53 PM
In T173360#3735212, @Ciencia_Al_Poder wrote:

Another thing is that it currently "fixes itself" the metadata information on page view, which is bad for T92357: Fix database master queries from HTTP GET/HEAD before active-active multi-dc.

Reported as T179760

• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.Nov 24 2017, 5:27 PM
xSavitar moved this task from Backlog to Doing on the good first task board.Jan 26 2018, 4:24 PM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:38 AM
Ciencia_Al_Poder removed Ciencia_Al_Poder as the assignee of this task.Mar 19 2020, 1:57 PM
dduvall mentioned this in T285431: PHP Notice: Undefined index: frameCount.Jun 23 2021, 7:58 PM
Umherirrender closed this task as Resolved.Feb 13 2023, 10:12 PM
Umherirrender subscribed.

GIFHandler was fixed with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500088
PNGHandler was fixed as part of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/693298

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits