Ref. T170940
Right not it doesn't make much sense to show one bar when we select "one month" in the timerange. We should probably use daily granularity in that case
Description
Description
Revisions and Commits
Revisions and Commits
| rWIKISTATS analytics-wikistats-new | |||
| rWIKISTATSb7ef2649163e Squashed commit of the following: | |||
| Restricted Differential Revision | rWIKISTATS623492721d36 Rotate x axis labels to improve legibility of charts | ||
| Restricted Differential Revision | rWIKISTATSca68136afb08 Make bar width constant | ||
| rWIKISTATS7e056414a481 Squashed commit of the following: | |||
| Restricted Differential Revision | rWIKISTATSca89efc85517 Switch granularity to daily when time range is either 3 or 1 months | ||
Related Objects
Related Objects
- Mentioned In
- T170940: Wikistats2 bugs (4/4) - Detail page
- Mentioned Here
- T170940: Wikistats2 bugs (4/4) - Detail page
Event Timeline
Comment Actions
This works ok from a data point of view, but there are two rendering problems:
- The X axis shrinks in 1-month and 3-month mode (compared to the 1-year mode). This should always be the same size regardless of the data, and that should be as wide as possible in the space it has.
- The labels overlap each other in the 1-month mode. This is very hard to get right with d3's crazy labeling, but give it a shot, it might be better in v4.
Comment Actions
The X axis shrinks in 1-month and 3-month mode (compared to the 1-year mode). This should always be the same size regardless of the data, and that should be as wide as possible in the space it has.
Yeah I got stuck with this. I've noooo idea how to make d3's scaleband to work with a fixed width. If we can brainstorm around this that'd be great.
The labels overlap each other in the 1-month mode. This is very hard to get right with d3's crazy labeling, but give it a shot, it might be better in v4.
D781