Page MenuHomePhabricator
Create Task
Maniphest T173394

Fatal error from AntiSpoof when logging in
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Logging in on test2.wikipedia.org should respond to the POST with a redirect back to the page I was reading, but instead serves an entirely empty page. Not even an "Internal error" error page from MediaWiki, or a generic 500 handler from Varnish either. Just nothing.

Screen Shot 2017-08-15 at 19.49.37.png (622×1 px, 144 KB)

[WZOHDApAMFAAAFYiPVwAAAAO] /w/index.php?title=Special:UserLogin&returnto=Special:Notifications   ErrorException from line 107 of /srv/mediawiki/php-1.30.0-wmf.14/extensions/AntiSpoof/SpoofUser.php: PHP Error: Argument 1 passed to SpoofUser::batchRecord() must be an instance of Wikimedia\Rdbms\Database, Wikimedia\Rdbms\DBConnRef given

That fact that this kind of exception can result in no error page to the user is its own problem.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Type-hint SpoofUser::batchRecord() for IDatabasemediawiki/extensions/AntiSpoofwmf/1.30.0-wmf.14+5 -5
Type-hint SpoofUser::batchRecord() for IDatabasemediawiki/extensions/AntiSpoofmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Aug 15 2017, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2017, 11:50 PM
Krinkle added a parent task: T170632: 1.30.0-wmf.14 deployment blockers.Aug 15 2017, 11:50 PM
gerritbot subscribed.Aug 16 2017, 3:42 AM

Change 372095 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/AntiSpoof@master] Type-hint SpoofUser::batchRecord() for IDatabase

https://gerrit.wikimedia.org/r/372095

gerritbot added a project: Patch-For-Review.Aug 16 2017, 3:42 AM
gerritbot added a comment.Aug 16 2017, 3:53 AM

Change 372095 merged by jenkins-bot:
[mediawiki/extensions/AntiSpoof@master] Type-hint SpoofUser::batchRecord() for IDatabase

https://gerrit.wikimedia.org/r/372095

gerritbot added a comment.Aug 16 2017, 3:56 AM

Change 372097 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/AntiSpoof@wmf/1.30.0-wmf.14] Type-hint SpoofUser::batchRecord() for IDatabase

https://gerrit.wikimedia.org/r/372097

Legoktm mentioned this in T170632: 1.30.0-wmf.14 deployment blockers.Aug 16 2017, 3:57 AM
Legoktm subscribed.

Should we split this into two tickets? One for the now-fixed AntiSpoof issue, and another for fatals being blank pages?

gerritbot added a comment.Aug 16 2017, 5:02 PM

Change 372097 merged by jenkins-bot:
[mediawiki/extensions/AntiSpoof@wmf/1.30.0-wmf.14] Type-hint SpoofUser::batchRecord() for IDatabase

https://gerrit.wikimedia.org/r/372097

Stashbot subscribed.Aug 16 2017, 5:07 PM

Mentioned in SAL (#wikimedia-operations) [2017-08-16T17:07:35Z] <demon@tin> Synchronized php-1.30.0-wmf.14/extensions/AntiSpoof/SpoofUser.php: T173394 (duration: 00m 51s)

thcipriani subscribed.Aug 16 2017, 5:19 PM
In T173394#3528219, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2017-08-16T17:07:35Z] <demon@tin> Synchronized php-1.30.0-wmf.14/extensions/AntiSpoof/SpoofUser.php: T173394 (duration: 00m 51s)

After this deployment, I am now redirected correctly.

In T173394#3526955, @Legoktm wrote:

Should we split this into two tickets? One for the now-fixed AntiSpoof issue, and another for fatals being blank pages?

Will leave this task open for the time being until tracking for blank page fatals is done, but removing as a train blocker.

thcipriani removed a parent task: T170632: 1.30.0-wmf.14 deployment blockers.Aug 16 2017, 5:19 PM
Krinkle renamed this task from Fatal error (blank page) served after logging in to Fatal error from AntiSpoof when logging in .Aug 17 2017, 1:56 AM
Krinkle closed this task as Resolved.
Krinkle triaged this task as Unbreak Now! priority.
Krinkle removed a project: Patch-For-Review.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptAug 17 2017, 1:56 AM
Krinkle mentioned this in T173481: Investigate why sign-up fatal resulted in a blank page and fix.Aug 17 2017, 2:03 AM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 21 2017, 6:02 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits