CodeMirror shouldn't register its enable/disable tools with the New Wikitext Editor unless the beta feature is enabled
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Per T172958#3528549, the 2017 WikiText Editor should not provide a Syntax Highlighting menu option unless $wgCodeMirrorBetaFeature is false or the syntax highlighting beta feature is enabled.

Details

	Subject	Repo	Branch	Lines +/-
	Respect beta feature in new wikitext editor	mediawiki/extensions/CodeMirror	master	+28 -14

Customize query in gerrit

Related Objects

Mentioned Here: T172958: CodeMirror is incompatible with new wikitext editor

Event Timeline

kaldari created this task.Aug 17 2017, 12:46 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 17 2017, 12:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 17 2017, 12:46 AM

• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Aug 21 2017, 9:04 AM

kaldari triaged this task as Medium priority.Aug 22 2017, 11:16 PM

kaldari set the point value for this task to 3.

Jdforrester-WMF renamed this task from New Wikitext Editor should only show syntax highlighting option when beta feature is enabled to CodeMirror shouldn't register its enable/disable tools with the New Wikitext Editor unless the beta feature is enabled.Aug 25 2017, 3:46 PM

Change 374898 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Respect beta feature in new wikitext editor

https://gerrit.wikimedia.org/r/374898

gerritbot added a project: Patch-For-Review.Aug 30 2017, 9:54 PM

• DannyH moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Sep 5 2017, 11:49 PM

kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.Sep 26 2017, 11:29 PM

Change 374898 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Respect beta feature in new wikitext editor

https://gerrit.wikimedia.org/r/374898

kaldari closed this task as Resolved.Sep 29 2017, 5:38 AM

kaldari claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 29 2017, 5:38 AM

kaldari moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.Sep 29 2017, 5:39 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 29 2017, 6:00 AM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Oct 3 2017, 9:46 PM