I think the [[]] icon for 'edit source' link (when VE is installed) looks stupid. Other people were just generally confused. Should probably be re-evaluated.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Better icons/handling for view source, VE edit links | mediawiki/skins/Timeless | master | +98 -49 |
Related Objects
Related Objects
- Mentioned In
- T301440: Design icon for "IP Reveal" action, possibly change VisualEditor icon
rSKINc337c3008e9c: Update git submodules
T229184: "View source" has no icon in mobile view of Timeless
T173205: `edit source` wrongly placed on the Timeless skin in mediawiki.org - Mentioned Here
- T197520: Use icons with text for actions etc at higher resolutions so people don't get confused when they switch to icons only at lower ones
T97451: Make source/wikitext icon consistent
T116417: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover
Event Timeline
Comment Actions
VE itself uses a pencil for the concept of editing, brackets for source editing and eye for visual editing. I think we settled on this unhappily after considering a few different things (T97451 and T116417 look relevant). If you invent a better metaphor, VE team might want to hear about it too
Either way it's probably a good idea for the skin and VE to be consistent. Perhaps you might just remove the brackets icon while keeping the pencil?
Comment Actions
Perhaps you might just remove the brackets icon while keeping the pencil?
Yeah, probably the sanest/easiest approach. And just move the pencil to the container of both edit and edit source so it shows up for both on editsection. And then the eyeball stuff for the cactions links...?
Comment Actions
It appears that the pencil icon is sometimes mistaken for a drawing tool: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2017_1#No_easy_way_to_get_back_to_VisualEditor
Comment Actions
Change 531523 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links
Comment Actions
Not sure what to do about the pencil icon, since it's all we got... maybe just see if we can reinforce what it means by using it more in general? (Basically T197520: Use icons with text for actions etc at higher resolutions so people don't get confused when they switch to icons only at lower ones could apply with this too...)
Comment Actions
Change 531523 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links