Page MenuHomePhabricator

New 'edit source' icon
Closed, ResolvedPublic

Description

I think the [[]] icon for 'edit source' link (when VE is installed) looks stupid. Other people were just generally confused. Should probably be re-evaluated.

Event Timeline

VE itself uses a pencil for the concept of editing, brackets for source editing and eye for visual editing. I think we settled on this unhappily after considering a few different things (T97451 and T116417 look relevant). If you invent a better metaphor, VE team might want to hear about it too

Either way it's probably a good idea for the skin and VE to be consistent. Perhaps you might just remove the brackets icon while keeping the pencil?

Perhaps you might just remove the brackets icon while keeping the pencil?

Yeah, probably the sanest/easiest approach. And just move the pencil to the container of both edit and edit source so it shows up for both on editsection. And then the eyeball stuff for the cactions links...?

Change 531523 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

Not sure what to do about the pencil icon, since it's all we got... maybe just see if we can reinforce what it means by using it more in general? (Basically T197520: Use icons with text for actions etc at higher resolutions so people don't get confused when they switch to icons only at lower ones could apply with this too...)

Change 531523 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

Isarra closed this task as Resolved.Aug 24 2019, 12:22 AM
Isarra claimed this task.

...I hope.