Call to a member function serialize() on a non-object (null)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seeing a few of these on wmf.14

#0 /srv/mediawiki/php-1.30.0-wmf.14/includes/specials/SpecialNewpages.php(486): SpecialNewpages->feedItemDesc(stdClass)
#1 /srv/mediawiki/php-1.30.0-wmf.14/includes/specials/SpecialNewpages.php(459): SpecialNewpages->feedItem(stdClass)
#2 /srv/mediawiki/php-1.30.0-wmf.14/includes/specials/SpecialNewpages.php(140): SpecialNewpages->feed(string)
#3 /srv/mediawiki/php-1.30.0-wmf.14/includes/specialpage/SpecialPage.php(522): SpecialNewpages->execute(NULL)
#4 /srv/mediawiki/php-1.30.0-wmf.14/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(868): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.30.0-wmf.14/includes/MediaWiki.php(523): MediaWiki->main()
#8 /srv/mediawiki/php-1.30.0-wmf.14/index.php(43): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+14 -9	Restore the newFromId() approach in SpecialNewpages::feedItemDesc
	mediawiki/core	wmf/1.30.0-wmf.14	+14 -9	Restore the newFromId() approach in SpecialNewpages::feedItemDesc

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	thcipriani	T170632 1.30.0-wmf.14 deployment blockers
		Resolved	PRODUCTION ERROR	aaron	T173541 Call to a member function serialize() on a non-object (null)

Event Timeline

thcipriani created this task.Aug 17 2017, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2017, 8:33 PM

greg added a project: MediaWiki-Special-pages.Aug 17 2017, 8:38 PM

Change 372447 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Make SpecialNewpages::feedItemDesc() handle null content

https://gerrit.wikimedia.org/r/372447

gerritbot added a project: Patch-For-Review.Aug 17 2017, 8:53 PM

Likely candidates:

Most likely 4475e1c8cb4 I think, assuming the error comes from $revision->getContent()->serialize() ) ). Presumably Revision::getContent() does not work on the partially populated Revision object we create as of commit 4475e1c8cb4.

Krinkle added a parent task: T170632: 1.30.0-wmf.14 deployment blockers.Aug 17 2017, 9:01 PM

Change 372465 had a related patch set uploaded (by Thcipriani; owner: Aaron Schulz):
[mediawiki/core@wmf/1.30.0-wmf.14] Restore the newFromId() approach in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/372465

Change 372465 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.14] Restore the newFromId() approach in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/372465

Krinkle closed this task as Resolved.Aug 17 2017, 10:03 PM

Krinkle assigned this task to aaron.

Krinkle triaged this task as High priority.

Mentioned in SAL (#wikimedia-operations) [2017-08-17T22:09:17Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.14/includes/specials/SpecialNewpages.php: [[gerrit:372465|Restore the newFromId() approach in SpecialNewpages::feedItemDesc]] T173541 (duration: 00m 46s)

Change 372447 merged by jenkins-bot:
[mediawiki/core@master] Restore the newFromId() approach in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/372447

Krinkle edited projects, added Performance-Team; removed Patch-For-Review.Aug 17 2017, 10:32 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 21 2017, 7:01 PM

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM

Call to a member function serialize() on a non-object (null)Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related ObjectsSearch...

Event Timeline

Call to a member function serialize() on a non-object (null)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Related Objects
Search...