Page MenuHomePhabricator
Create Task
Maniphest T173642

UploadWizard campaigns showing cached template output
Closed, ResolvedPublic
Actions

Description

WLM campaigns in Wikimedia Commons use the data embedded on Template:WLM-is-running for switching its headerLabel

See for instance https://commons.wikimedia.org/w/index.php?title=Campaign:wlm-es&action=edit

A couple of days ago I edited this template so it no longer showed the competitions as closed:
https://commons.wikimedia.org/w/index.php?title=Template:WLM-is-running&diff=255698896&oldid=253210886

However, for the languages where it was viewed, the old output ("Wiki Loves Monuments 2017 is closed.") is still shown:
https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-es&uselang=en

whereas if you provide a language that had not been viewed, the correct output ("Wiki Loves Monuments 2017 has not started yet.") is provided:
https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wlm-es&uselang=asdf

Adding &action=purge to either the Campaign page or the Special:UploadWizard url does not work. However, it can be fixed with a null edit to the Campaign page.

This might be just a matter of the job queue not having yet processed the campaign page. The job queue has been growing since August 7th. But reading the job wait time, I would have expected it to have been processed by now (for refreshLinks jobs, the 95th percentile is 7 hours, although the 99th percentile goes up to 2 days). However, given that it is showed in the interface, it may not be a typical job queue delay.

Links: job count, job queue health, job queue rate

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Expire cached campaign configsSimon04mediawiki/extensions/UploadWizardmaster+153 -69
Don't share the parsed config cache with old campaign revisionsSimon04mediawiki/extensions/UploadWizardmaster+98 -6
Customize query in gerrit

Related Objects

Event Timeline

Platonides created this task.Aug 19 2017, 11:34 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 19 2017, 11:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dr0ptp4kt triaged this task as High priority.Aug 21 2017, 4:55 PM
dr0ptp4kt moved this task from Untriaged to Next up on the Multimedia board.
dr0ptp4kt subscribed.

Needs technical investigation.

MarkTraceur subscribed.Aug 21 2017, 6:28 PM

So, I did a quick look, and here's my take on this so far...

First, the page looks good now for uselang=en, so the cache has invalidated, but the several-days lag does concern me.

Second, the *code* looks like it properly invalidates parsed configuration values based on when the template changes, so maybe this is just a question of the cache responding slowly (or linkupdate jobs, or whatever).

I'd say, try changing it again, and see if it still takes several days. I'll take a second look if it does.

MarkTraceur lowered the priority of this task from High to Low.Aug 28 2017, 4:40 PM
MarkTraceur moved this task from Next up to Triaged on the Multimedia board.
JeanFred mentioned this in T174914: [2017] UploadCampaign sometimes use old autoAdd configuration.Sep 4 2017, 10:54 AM
JeanFred subscribed.EditedSep 5 2018, 3:58 PM

This is still happening:

  • I created yesterday evening a campaign with a plain text description
  • 10 hours later, I switched to use an autotranslated template (which includes an image), add a French translation, and purge template, i18n subpage, and campaign
  • 8 hours later, a user adds a translation in Portuguese.

Now, 2 hours after that last event, in a private browser window I get:

  • Campaign:MuseuNacional?uselang=en displays the old message (without the image) (bad)
  • Campaign:MuseuNacional?uselang=fr displays the new message (with the image) in French (good)
  • Campaign:MuseuNacional?uselang=pt displays the new message (with the image) but in English (bad)

The original report indicated that dummy-edits on the Campaign page helped, but I did that, and two actual edits, and still get the same.

Tiven2240 mentioned this in T303019: UploadWizard campaigns showing campaign has ended.Mar 4 2022, 4:38 AM
dr0ptp4kt unsubscribed.Jul 28 2023, 3:50 PM
Ciell removed a project: Wiki-Loves-Monuments.Aug 26 2025, 10:47 AM
gerritbot added a comment.Fri, Oct 2, 4:46 PM

Change #1348810 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@master] Don't share the parsed config cache with old campaign revisions

https://gerrit.wikimedia.org/r/1348810

gerritbot added a project: Patch-For-Review.Fri, Oct 2, 4:46 PM

Change #1348817 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@master] Expire cached campaign configs

https://gerrit.wikimedia.org/r/1348817

simon04 claimed this task.Fri, Oct 2, 7:55 PM
simon04 moved this task from Backlog to Campaign on the UploadWizard board.Sat, Oct 3, 7:00 AM
gerritbot added a comment.Sat, Oct 3, 10:55 AM

Change #1348810 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Don't share the parsed config cache with old campaign revisions

https://gerrit.wikimedia.org/r/1348810

gerritbot added a comment.Sat, Oct 3, 11:28 PM

Change #1348817 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Expire cached campaign configs

https://gerrit.wikimedia.org/r/1348817

Maintenance_bot removed a project: Patch-For-Review.Sat, Oct 3, 11:30 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.23; 2026-10-06).Sun, Oct 4, 12:00 AM
simon04 closed this task as Resolved.Tue, Oct 6, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits