Page MenuHomePhabricator
Create Task
Maniphest T173739

Improve constraints gadget layout
Closed, ResolvedPublic
Actions

Assigned To
Lucas_Werkmeister_WMDE
Authored By
Lucas_Werkmeister_WMDE
Aug 21 2017, 4:04 PM
Tags
Referenced Files
F9226175: Screen Shot 2017-08-30 at 17.41.47.png
Aug 30 2017, 3:42 PM
F9145683: image.png
Aug 22 2017, 7:55 AM
F9145643: image.png
Aug 22 2017, 7:55 AM
F9145608: image.png
Aug 22 2017, 7:55 AM
Subscribers
Aklapper
gerritbot
Jan_Dittrich
Lucas_Werkmeister_WMDE

Description

@Jan_Dittrich suggested the following improvements to the gadget layout:

  • Remove the border between constraint report sections. They should be separated by vertical space only.
  • Remove some vertical space between the heading and message of an individual constraint report.

Details

SubjectRepoBranchLines +/-
Improve constraints gadget layoutmediawiki/extensions/WikibaseQualityConstraintsmaster+4 -5
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 21 2017, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2017, 4:04 PM
Lydia_Pintscher renamed this task from Improve gadget layout to Improve constraints gadget layout.Aug 21 2017, 4:35 PM
Jan_Dittrich added a comment.Aug 22 2017, 7:55 AM

indeed.

old:

image.png (370×424 px, 28 KB)

proposed change:

image.png (319×424 px, 33 KB)

principle:

image.png (482×292 px, 8 KB)

Lucas_Werkmeister_WMDE added a comment.Aug 30 2017, 3:42 PM

How’s this?

Screen Shot 2017-08-30 at 17.41.47.png (455×402 px, 32 KB)

gerritbot subscribed.Aug 30 2017, 4:04 PM

Change 374839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve constraints gadget layout

https://gerrit.wikimedia.org/r/374839

gerritbot added a project: Patch-For-Review.Aug 30 2017, 4:04 PM
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.Aug 30 2017, 4:04 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.
Lucas_Werkmeister_WMDE moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Aug 31 2017, 8:41 AM
gerritbot added a comment.Sep 6 2017, 1:11 PM

Change 374839 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve constraints gadget layout

https://gerrit.wikimedia.org/r/374839

Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 6 2017, 1:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL