WDQS hardcodes query.wikidata.org URL
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Yurik
	Aug 21 2017, 8:50 PM

Description

https://github.com/wikimedia/wikidata-query-gui/blob/master/embed.html#L256 and many other places hardcode https://query.wikidata.org URL.
It makes it impossible to host it somewhere else with a local DB, and to perform proper tests unbound to production.

P.S. reported at https://www.mediawiki.org/wiki/Topic:Twnti584yjng6fcc

Details

	Subject	Repo	Branch	Lines +/-
	Make base URL configurable and use i18n in embed for edit link	wikidata/query/gui	master	+15 -5
	Refactor embed.html to use ResultView	wikidata/query/gui	master	+119 -122

Customize query in gerrit

Related Objects

Mentioned In: rWDQG85dafa8f0fbb: Update patch set 8
rWDQGdd3a4955369e: Make base URL configurable and use i18n in embed for edit link
rWDQG09f9491263d3: Refactor embed.html to use ResultView
rWDQG81a59b2aff9e: Make base URL configurable and use i18n in embed for edit link
rWDQG659465adcc88: Make base URL configurable and use i18n in embed for edit link
rWDQG44ab15ab7032: Refactor embed.html to use ResultView
rWDQG570aabb15036: Refactor embed.html to use ResultView

Event Timeline

Yurik created this task.Aug 21 2017, 8:50 PM

Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptAug 21 2017, 8:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Yurik updated the task description. (Show Details)Aug 21 2017, 8:50 PM

Smalyshev moved this task from Incoming to GUI on the Wikidata-Query-Service board.Aug 21 2017, 8:50 PM

Smalyshev added a subscriber: • Jonas.

Yurik updated the task description. (Show Details)Aug 21 2017, 8:58 PM

Yurik updated the task description. (Show Details)Aug 21 2017, 9:24 PM

• Jonas mentioned this in rWDQG570aabb15036: Refactor embed.html to use ResultView.Aug 21 2017, 9:31 PM

Change 371616 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[wikidata/query/gui@master] Refactor embed.html to use ResultView

https://gerrit.wikimedia.org/r/371616

gerritbot added a project: Patch-For-Review.Aug 21 2017, 9:34 PM

• Jonas mentioned this in rWDQG44ab15ab7032: Refactor embed.html to use ResultView.Aug 21 2017, 9:34 PM

Change 373031 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[wikidata/query/gui@master] Make base URL configurable and use i18n in embed for edit link

https://gerrit.wikimedia.org/r/373031

• Jonas edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.Aug 22 2017, 8:38 AM

• Jonas moved this task from Backlog to Doing on the Wikidata Query UI board.

• Jonas mentioned this in rWDQG659465adcc88: Make base URL configurable and use i18n in embed for edit link.Aug 22 2017, 8:40 AM

Lucas_Werkmeister_WMDE mentioned this in rWDQG81a59b2aff9e: Make base URL configurable and use i18n in embed for edit link.Aug 22 2017, 2:04 PM

• Jonas mentioned this in rWDQG09f9491263d3: Refactor embed.html to use ResultView.Aug 27 2017, 9:16 PM

Change 371616 merged by jenkins-bot:
[wikidata/query/gui@master] Refactor embed.html to use ResultView

https://gerrit.wikimedia.org/r/371616

• Jonas mentioned this in rWDQGdd3a4955369e: Make base URL configurable and use i18n in embed for edit link.Aug 31 2017, 7:54 AM

Change 373031 merged by jenkins-bot:
[wikidata/query/gui@master] Make base URL configurable and use i18n in embed for edit link

https://gerrit.wikimedia.org/r/373031

• Jonas triaged this task as Lowest priority.Aug 31 2017, 7:57 AM