Page MenuHomePhabricator
Create Task
Maniphest T173782

Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException»
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To
Umherirrender
Authored By
Base
Aug 21 2017, 9:17 PM
Project Tags
Referenced Files
F34130406: Screenshot_2021-03-01 Internal error - Meta.png
Mar 1 2021, 6:09 PM
Subscribers
Aklapper
• AndyRussG
Base
Ciell
• DStrine
• Jseddon
• Lucas_Werkmeister_WMDE
View All 12 Subscribers

Description

Encountered
[WZtMzQpAMFMAAFSENMYAAABT] 2017-08-21 21:12:45: Критичний виняток типу «BannerDataException»
[WZtNDQpAAEMAAJN7L4sAAABE] 2017-08-21 21:13:50: Критичний виняток типу «BannerDataException»
[WZtNaApAMFEAAH29CTAAAABA] 2017-08-21 21:15:21: Критичний виняток типу «BannerDataException»
[WZtOJwpAMFUAAEgb798AAAAR] 2017-08-21 21:18:32: Критичний виняток типу «BannerDataException»
[WZtXMwpAIDUAAFCNohsAAAAY] 2017-08-21 21:57:08: Критичний виняток типу «BannerDataException»
when trying to clone https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/Community_banner_template with name of WikiEncuentro-Cali-2017 and desc of [[CentralNotice/Request/WikiEncuentro Cali 2017]].

Error

message
BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.16/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(922): Banner->cloneBanner(string, User, string)
#1 /srv/mediawiki/php-1.35.0-wmf.16/includes/htmlform/HTMLForm.php(694): SpecialCentralNoticeBanners->processEditBanner(array, CentralNoticeHtmlForm)
#2 /srv/mediawiki/php-1.35.0-wmf.16/includes/htmlform/HTMLForm.php(586): HTMLForm->trySubmit()
#3 /srv/mediawiki/php-1.35.0-wmf.16/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(452): HTMLForm->tryAuthorizedSubmit()
#4 /srv/mediawiki/php-1.35.0-wmf.16/extensions/CentralNotice/includes/specials/SpecialCentralNoticeBanners.php(90): SpecialCentralNoticeBanners->showBannerEditor()
#5 /srv/mediawiki/php-1.35.0-wmf.16/includes/specialpage/SpecialPage.php(575): SpecialCentralNoticeBanners->execute(string)
#6 /srv/mediawiki/php-1.35.0-wmf.16/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(string)
#7 /srv/mediawiki/php-1.35.0-wmf.16/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.35.0-wmf.16/includes/MediaWiki.php(967): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.35.0-wmf.16/includes/MediaWiki.php(530): MediaWiki->main()
#10 /srv/mediawiki/php-1.35.0-wmf.16/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Validate banner name on SpecialCentralNoticeBanners for delete and cloneUmherirrendermediawiki/extensions/CentralNoticemaster+8 -1
Use specific error message when banner name missing/invalidMeppsmediawiki/extensions/CentralNoticemaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Base created this task.Aug 21 2017, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2017, 9:17 PM
Base updated the task description. (Show Details)Aug 21 2017, 9:18 PM
Base moved this task from Q3-2017 to Issues on the Wikimedia-CentralNotice-Administration board.Aug 21 2017, 9:54 PM
Base edited projects, added: Wikimedia-CentralNotice-Administration; removed: Wikimedia-CentralNotice-Administration (Q3-2017).
Base updated the task description. (Show Details)Aug 21 2017, 9:57 PM
Base added a comment.Aug 21 2017, 9:59 PM

Worked for the name of [[https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/Edit/WikiEncuentro_Cali_2017|WikiEncuentro_Cali_2017]] (though it took over 5s to be done). Are hyphens the culprit or just a coincidence?

Aklapper removed a project: SRE.Aug 22 2017, 7:57 AM

@Base: Why was this tagged as SRE ? Removing...

Are hyphens the culprit or just a coincidence?

Yes: [WZtXMwpAIDUAAFCNohsAAAAY] /wiki/Special:CentralNoticeBanners/edit/Community_banner_template BannerDataException from line 1069 of /srv/mediawiki/php-1.30.0-wmf.14/extensions/CentralNotice/includes/Banner.php: Banner name must be in format /^[A-Za-z0-9_

So maybe this task should be named "Display a sane error if the banner name is bad".

Aklapper edited projects, added: MediaWiki-extensions-CentralNotice; removed: MediaWiki-extensions-CentralAuth.Aug 22 2017, 7:58 AM

I don't see any relation to MediaWiki-extensions-CentralAuth either here - removing.

Base added a comment.Aug 22 2017, 9:05 AM

(Operations as a blind choice for someone to sort out errors, and CentralAuth was a typo, I was sure I selected CentralNotice)

Yes, given the hyphen is confirmed to be behind this rather than some bug, the suggested name for the task looks good to me too :)

Aklapper renamed this task from «BannerDataException» when trying to clone a banner to Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException» (when trying to clone a banner).Aug 22 2017, 10:36 AM
Aklapper removed a project: Wikimedia-production-error.
• DStrine added a project: Fundraising-Backlog.Aug 22 2017, 3:09 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Aug 22 2017, 7:45 PM
MarcoAurelio merged a task: T212060: CentralNotice doesn't warn if attempted banner name doesn't match permitted regex.Dec 16 2018, 11:59 AM
MarcoAurelio added subscribers: MarcoAurelio, Reedy.

This has happened again, see above merged tasks.

• mepps subscribed.Aug 29 2019, 2:03 PM

The error display was resolved in https://phabricator.wikimedia.org/T149240, in that it now says "You do not have the correct permissions to perform the requested action or the action itself was invalid." as opposed to a full stack trace. However, I wonder if it's worth displaying the specific error message when a user inputs an invalid format.

gerritbot added a comment.Aug 29 2019, 4:01 PM

Change 533253 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/CentralNotice@master] Use specific error message when banner name missing/invalid

https://gerrit.wikimedia.org/r/533253

gerritbot added a project: Patch-For-Review.Aug 29 2019, 4:01 PM
gerritbot added a comment.Sep 9 2019, 7:02 AM

Change 533253 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use specific error message when banner name missing/invalid

https://gerrit.wikimedia.org/r/533253

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2019, 7:10 AM
• Lucas_Werkmeister_WMDE mentioned this in T244020: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/.Jan 31 2020, 12:40 PM
gerritbot added a comment.Jul 11 2020, 11:28 AM

Change 611713 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/CentralNotice@master] Validate banner name on SpecialCentralNoticeBanners for delete and clone

https://gerrit.wikimedia.org/r/611713

gerritbot added a project: Patch-For-Review.Jul 11 2020, 11:28 AM
Krinkle renamed this task from Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException» (when trying to clone a banner) to Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException».Sep 10 2020, 6:45 PM
Krinkle added a project: Wikimedia-production-error.
Krinkle changed the subtype of this task from "Task" to "Production Error".
Krinkle updated the task description. (Show Details)
Krinkle merged a task: T244020: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/.
Krinkle moved this task from Untriaged to Feb2020/1.35-wmf.18 on the Wikimedia-production-error board.
Krinkle added subscribers: • Lucas_Werkmeister_WMDE, Quiddity, • Jseddon and 4 others.
Umherirrender subscribed.Feb 22 2021, 5:57 PM

Would be nice to get a feedback if the provided patch set is the right way to fix the issue or not.
That would allow to unblock the task by merging the patch set. Or abandon the patch set and make it free for another try from another developer, but a task with patch set maybe not getting much attention for other solutions.

Ciell added a comment.Mar 1 2021, 6:09 PM

I'm not sure if you mean me for testing, but for me it doesn't work yet.
(see screenshot)

Screenshot_2021-03-01 Internal error - Meta.png (1,678×205 px, 10 KB)

Krinkle unsubscribed.Mar 1 2021, 7:43 PM
gerritbot added a comment.Mar 6 2021, 3:17 PM

Change 611713 abandoned by Umherirrender:
[mediawiki/extensions/CentralNotice@master] Validate banner name on SpecialCentralNoticeBanners for delete and clone

Reason:
Seems not the right way to do it, unblock the task for other developer to find a better way.

https://gerrit.wikimedia.org/r/611713

Umherirrender removed a project: Patch-For-Review.Mar 6 2021, 3:18 PM
Umherirrender unsubscribed.
Krinkle moved this task from Feb2020/1.35-wmf.18 to Older on the Wikimedia-production-error board.Mar 15 2021, 11:14 PM
• DStrine triaged this task as Low priority.Mar 16 2021, 7:59 PM
• DStrine moved this task from Q3 2021-2022 to Current Sprint on the Fundraising-Backlog board.
• DStrine added a project: Fundraising Sprint File Systems Stage Show.Mar 16 2021, 8:03 PM
• DStrine added a project: Fundraising Sprint Git Rebase Jump.Mar 30 2021, 8:28 PM
• AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Git Rebase Jump board.Apr 7 2021, 2:54 AM
gerritbot added a comment.Apr 7 2021, 3:56 PM

Change 611713 restored by AndyRussG:

[mediawiki/extensions/CentralNotice@master] Validate banner name on SpecialCentralNoticeBanners for delete and clone

https://gerrit.wikimedia.org/r/611713

gerritbot added a project: Patch-For-Review.Apr 7 2021, 3:56 PM
• AndyRussG added subscribers: Umherirrender, • AndyRussG.Apr 7 2021, 3:59 PM

@Umherirrender the patch you sent looks fine. Many, many apologies to all that we hadn't gotten to this sooner. I've restored the patch, and we'll merge it shortly. Thanks so much and apologies again!!

• AndyRussG moved this task from Doing to Review on the Fundraising Sprint Git Rebase Jump board.Apr 7 2021, 4:05 PM
Quiddity unsubscribed.Apr 7 2021, 6:02 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Git Rebase Jump board.Apr 8 2021, 2:58 AM
gerritbot added a comment.Apr 8 2021, 3:00 AM

Change 611713 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Validate banner name on SpecialCentralNoticeBanners for delete and clone

https://gerrit.wikimedia.org/r/611713

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 8 2021, 4:00 AM
Umherirrender closed this task as Resolved.Apr 8 2021, 11:12 AM
Umherirrender claimed this task.
In T173782#6980729, @AndyRussG wrote:

@Umherirrender the patch you sent looks fine. Many, many apologies to all that we hadn't gotten to this sooner. I've restored the patch, and we'll merge it shortly. Thanks so much and apologies again!!

Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits