Page MenuHomePhabricator
Create Task
Maniphest T173877

Create Phab account for "jenkins-bot / Gerrit Code Review" to set an avatar image to ease recognition in commit histories
Closed, ResolvedPublic
Actions

Description

[Tentative suggestion...]

Problem: As someone who is skimming through lists of commits, it is hard to distinguish actions by jenkins-bot / Gerrit Code Review, from other users with the default avatar images. E.g. https://phabricator.wikimedia.org/diffusion/EVED/history/master/

Suggestion: It might be helpful to give this bot a phabricator account and a simple (easily ignorable) avatar image? e.g. a white square?

whitesquare.png (150×150 px, 337 B)

Just a thought!

See also: T172048: Avatar for Translation updater bot and L10n-bot to allow separation

Related Objects

Event Timeline

Quiddity created this task.Aug 22 2017, 9:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2017, 9:12 PM
hashar edited projects, added Phabricator-Bot-Requests, Release-Engineering-Team; removed Jenkins.Aug 28 2017, 10:45 AM
hashar added subscribers: • demon, 20after4, hashar.

In CI, that is Zuul submitting the changes in Gerrit with the jenkins-bot user. Gerrit crafts the merge message with:

commit f315c650f62097b80fd03a8b2d73001c1a7ac3e0
Merge: 2abb9b1b2 b11b144ad
Author: jenkins-bot <jenkins-bot@gerrit.wikimedia.org>
AuthorDate: Thu Aug 24 17:18:54 2017 +0000
Commit: Gerrit Code Review <gerrit@wikimedia.org>
CommitDate: Thu Aug 24 17:18:54 2017 +0000

So I guess boths users have to be configured somehow in Phabricator. Maybe they just need accounts to be created?

• demon unsubscribed.Aug 28 2017, 4:11 PM
greg moved this task from INBOX to Backlog on the Release-Engineering-Team board.Aug 28 2017, 4:44 PM
greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.
Aklapper renamed this task from Avatar for jenkins-bot to ease recognition to Create Phab account for "jenkins-bot / Gerrit Code Review" to set an avatar image to ease recognition in commit histories.Apr 17 2018, 8:38 AM
Aklapper triaged this task as Lowest priority.
Aklapper edited projects, added Phabricator; removed Phabricator-Bot-Requests.
Peachey88 subscribed.Apr 17 2018, 10:24 AM
hashar unsubscribed.Apr 19 2018, 6:00 AM
Aklapper moved this task from To Triage to Administration (UI) on the Phabricator board.Aug 29 2018, 6:43 PM
Aklapper claimed this task.Apr 7 2019, 9:54 AM

I created https://phabricator.wikimedia.org/p/jenkins-bot/ via https://phabricator.wikimedia.org/people/new/bot/ and set the email address of jenkins-bot shown in the tooltip on https://phabricator.wikimedia.org/diffusion/EVED/history/master/ so I hope that this will automagically work in a few hours, days, months, years?

Aklapper closed this task as Resolved.Apr 7 2019, 6:26 PM
Aklapper added a project: Developer-Advocacy (Apr-Jun 2019).

Works at https://phabricator.wikimedia.org/source/mediawiki/history/master/ hence closing

Peachey88 added a comment.EditedApr 8 2019, 10:24 AM

Do we need to rebuild-identities (T77959#5055082) as well to pickup instances of usage before the account was created?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits