Page MenuHomePhabricator

Images in feed / news not loading consistently
Closed, ResolvedPublic1 Estimated Story Points

Description

I don't have retro steps, but I've seen 2 independent reports of images in the feed not loading in the past week so I want to capture this here.

Most recently from @dr0ptp4kt:

IMG_1891.jpg (3×4 px, 3 MB)

And one from @ori:

Screenshot_20170813-111050.png (1×1 px, 812 KB)

Should we see if @ABorbaWMF can reproduce reliably?

Event Timeline

I haven't seen any problems with image loading generally.

In @ori's case it looks like the "2017 Unite the Right rally" page moved and the API provides no thumbnail for the old title. We don't make any provision for handling page moves here.

In @dr0ptp4kt's case, it looks like the device is in airplane mode, and that photo looks consistent with having feed content partially cached, though that's just a guess. I can't repro. It would be cool if @ABorbaWMF could take a stab at it.

Is this the stable app?

Device/Android version?

Thanks, both, for reporting!

Mholloway renamed this task from [BUG] Images in feed / news not loading consistently to Images in feed / news not loading consistently.Aug 23 2017, 2:09 PM
Mholloway set the point value for this task to 1.

Here's my config:

  • Stable just released app
  • Nexus 7 w/ Android 5.1.1
  • 3G capable, but airplane mode on to disable cellular functionality; using non-congested home wifi on fast downlink - not offline

Change 373377 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Update Fresco to 1.5.0.

https://gerrit.wikimedia.org/r/373377

Change 373377 merged by jenkins-bot:
[apps/android/wikipedia@master] Update Fresco to 1.5.0.

https://gerrit.wikimedia.org/r/373377

Change 373405 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix inconsistent image loading on older APIs.

https://gerrit.wikimedia.org/r/373405

Change 373405 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix inconsistent image loading on older APIs.

https://gerrit.wikimedia.org/r/373405

@dr0ptp4kt Mind trying again with the latest alpha?

Tried with 2.6.201-alpha-2017-08-24 and the issue doesn't seem to be surfacing.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-25

Sorry I looked at this a while ago and apparently forgot to add comments. I was unable to reproduce it. I tried again on the latest build and it is not happening for me.