autoload.ide.php needs to be updated or removed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Aug 23 2017, 5:31 AM

Description

rMW3ca13774e244: PHPUnit autoload file for PhpStorm

autoload.ide.php has been technical debt ever since it was added, given that it was mostly copy-paste from phpunit.php and doMaintenance.php (as documented in the commit message).

With https://gerrit.wikimedia.org/r/#/c/373174/ this file is now falling behind because it does weird hacky stuff. We should figure out how to get rid of it and support IDEs with the normal phpunit running mechanism.

Details

	Subject	Repo	Branch	Lines +/-
	Delete autoload.ide.php	mediawiki/core	master	+0 -103

Customize query in gerrit

Related Objects

Mentioned In: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php
Mentioned Here: rMW3ca13774e244: PHPUnit autoload file for PhpStorm

Event Timeline

Legoktm created this task.Aug 23 2017, 5:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2017, 5:31 AM

WMDE-leszek subscribed.Aug 23 2017, 6:53 AM

Ricordisamoa subscribed.Aug 23 2017, 11:32 AM

Is this task considered TD because it's essentially duplicate code (reading into the "mostly copy-paste" comment)?

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Aug 30 2017, 10:26 PM

Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Nov 10 2017, 12:37 AM

With https://gerrit.wikimedia.org/r/c/mediawiki/core/+/451636 this file will fall even more behind, so I think we can just remove it now, given that it's seemingly unmaintained.

In T173899#3547391, @Jrbranaa wrote:

Is this task considered TD because it's essentially duplicate code (reading into the "mostly copy-paste" comment)?

Yep.

Change 451681 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Delete autoload.ide.php

https://gerrit.wikimedia.org/r/451681

gerritbot added a project: Patch-For-Review.Aug 9 2018, 6:25 PM

Change 451681 merged by jenkins-bot:
[mediawiki/core@master] Delete autoload.ide.php

https://gerrit.wikimedia.org/r/451681

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 12 2018, 8:00 AM

Legoktm closed this task as Resolved.Aug 12 2018, 8:12 AM

Legoktm assigned this task to Simetrical.

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:53 PM

Mainframe98 mentioned this in T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.Dec 27 2019, 10:58 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 27 2019, 11:10 AM