Once migrated drop the unnecessary function and command line arguments.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lokal_Profil | T173693 Move all dataset/monument type specific information into the class file | |||
| Declined | None | T173910 Rewrite of existing COH migration classes to bring them up to date with T173693 |
Event Timeline
Comment Actions
Implemented this, with an old half-finished patch, so that re-use is clearer if anyone wants to add more countries.
Comment Actions
As a last cleanup step we could probably remove or clearly label the country classes (in master) which were never finished/implemented.
Taking ZaEn as an example the ideal case would probably be to:
- Removing the ZaEn file from master
- Update the ZaEn patch/PR to include a first commit where the file is created.
Comment Actions
T173910#3802840 is left to do but should be broken out as a separate task listing the affected countries.
Comment Actions
Realistically this will never happen. If we decide to pick up the monuments migration again, setting it up in Openrefine from scratch will be faster and less prone to mistakes than reviving the COH codebase.