Implement desktop banner in wp.de
Open, Needs TriagePublic13 Story Points

Description

  • Add a CSS file that creates .org-like environment for the banner on wp.de, reuse the existing desktop banner.
  • Add a preview version for proxied development.
  • Move assets (images) from FoundraisingBanners into dev environment and compile them together with the rest of the banner.

banner for wp.de

Deployed changes to wikipedia.de

Pablo-WMDE added a comment.EditedMon, Sep 25, 3:57 PM

@gabriel-wmde Do you think we can lose fundraising-banners:dist/jquery.cookie.js? Seems redundant with the applications (dot org, dot de) shipping it themselves.

It'll be needed again for the "train mode" but until that is implemented, we can delete it.

Pablo-WMDE removed Pablo-WMDE as the assignee of this task.Tue, Sep 26, 10:07 AM
Pablo-WMDE moved this task from Doing to Todo on the WMDE-Fundraising-Sprint-11 board.
Pablo-WMDE added a subscriber: Pablo-WMDE.
Pablo-WMDE claimed this task.
Pablo-WMDE added a subscriber: kai.nissen.EditedMon, Oct 9, 8:45 AM

@gabriel-wmde @kai.nissen
Banners on .org are position: fixed; while the referenced .de banner seems to push the existing page content down more like normal element flow. Is this always the case or decided on a case by case basis? Should it be part of the "solution" of this ticket?

Most banners now have this "Rollo" effect where the banner pushes down content, so it's very likely the the banners on wpde will have that effect too. how it is implemented (position:fixed or something else) was decided on a case by case basis by the implementers of the banners. My personal opinion is to implement is as reusable and standardized as possible, so we can have less and less code in the banners themselves and more and more code in the shared folder.

The position should not be part of the ticket since we don't know yet which banner from .org will be the first banner on .de and we don't want to do the adjustments/refactorings twice.

PR https://github.com/wmde/fundraising-banners/pull/21 - review, please.

Will look into "pushing down content" for wp.de + some skin refactoring in a dedicated branch.

Pablo-WMDE added a comment.EditedMon, Oct 9, 3:50 PM

Additional PR https://github.com/wmde/fundraising-banners/pull/26
There probably exist some conflict w/ https://phabricator.wikimedia.org/T176226 which was refactored in parallel.

Pablo-WMDE removed Pablo-WMDE as the assignee of this task.
Pablo-WMDE added a comment.EditedMon, Oct 9, 4:02 PM

On prod there is still the untracked /FundraisingBanners folder, needed for older banners. If it's ok that older banners break (CSS-wise this is already partially the case), I'd prefer we remove it.

@kai.nissen @tmletzko
Would be great to get a hard requirement on this. Would screenshots suffice?