Page MenuHomePhabricator
Create Task
Maniphest T174017

Fix "LogicException from JobQueueGroup.php: Domain ... not recognized."
Closed, ResolvedPublic
Actions

Description

MediaWiki	1.30.0-alpha (439597c)
PHP	7.1.1 (apache2handler)
MariaDB	10.1.21-MariaDB
ICU	57.1
[exception] [637adf14a8e6c71e18811473] /mw-master/index.php?title=YetAgainAMediaWikiIssue&action=submit   LogicException from line 136 of ...\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\includes\jobqueue\JobQueueGroup.php(218): JobQueueGroup->push(array)
#1 ...\includes\deferred\MWCallableUpdate.php(30): JobQueueGroup::pushLazyJobs()
#2 ...\includes\deferred\DeferredUpdates.php(257): MWCallableUpdate->doUpdate()
#3 ...\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#4 ...\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#5 ...\includes\MediaWiki.php(911): DeferredUpdates::doUpdates(string)
#6 ...\includes\MediaWiki.php(738): MediaWiki->restInPeace(string)
#7 ...\includes\MediaWiki.php(757): MediaWiki->{closure}()
#8 ...\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#9 ...\index.php(43): MediaWiki->run()
#10 {main}
[DBConnection] Connected to database 0 at 'localhost'.
[runJobs] recentChangesUpdate Special:RecentChanges type=cacheUpdate requestId=637adf14a8e6c71e18811473 (id=1146,timestamp=20170824125007) STARTING
[exception] [637adf14a8e6c71e18811473] /mw-master/index.php?title=YetAgainAMediaWikiIssue&action=submit   LogicException from line 136 of ...\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\includes\jobqueue\JobQueueGroup.php(218): JobQueueGroup->push(array)
#1 ...\includes\deferred\MWCallableUpdate.php(30): JobQueueGroup::pushLazyJobs()
#2 ...\includes\deferred\DeferredUpdates.php(257): MWCallableUpdate->doUpdate()
#3 ...\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#4 ...\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#5 ...\includes\jobqueue\JobRunner.php(301): DeferredUpdates::doUpdates()
#6 ...\includes\jobqueue\JobRunner.php(193): JobRunner->executeJob(RecentChangesUpdateJob, Wikimedia\Rdbms\LBFactorySimple, BufferingStatsdDataFactory, integer)
#7 ...\includes\MediaWiki.php(978): JobRunner->run(array)
#8 ...\includes\MediaWiki.php(964): MediaWiki->triggerSyncJobs(integer, MediaWiki\Logger\LegacyLogger)
#9 ...\includes\MediaWiki.php(916): MediaWiki->triggerJobs()
#10 ...\includes\MediaWiki.php(738): MediaWiki->restInPeace(string)
#11 ...\includes\MediaWiki.php(757): MediaWiki->{closure}()
#12 ...\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#13 ...\index.php(43): MediaWiki->run()
#14 {main}

The test DB is stored as mw-master, somehow MW seems to assume Domain 'mw?hmaster' .

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clean up wiki ID and DB domain ID handlingmediawiki/coreREL1_30+68 -24
Clean up wiki ID and DB domain ID handlingmediawiki/coremaster+68 -24
Customize query in gerrit

Related Objects

Event Timeline

mwjames created this task.Aug 24 2017, 12:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2017, 12:59 PM
mwjames added a comment.Aug 24 2017, 1:04 PM

I reckoned there was a similar issue [0] in the past and I would have expected that a unit test is in place that would prevent such a regression.

[0] https://phabricator.wikimedia.org/T145840

mwjames added a subscriber: aaron.Sep 9 2017, 1:39 PM

@aaron

I was patiently awaiting (two weeks+) this issue to be triaged since this is clearly a regression since 1.29!

mwjames added a comment.Sep 23 2017, 4:44 AM

Do we think that this is going to be fixed in 1.30, given that it has a valid exception stack trace?

Legoktm subscribed.EditedSep 23 2017, 5:11 AM

@mwjames You know how to mark bugs as release blockers, so if there's a regression you've found and want to see it fixed, mark it as a release blocker. :)

In this case it looks like something is calling JobQueueGroup::singleton( $wiki )->lazyPush( $jobs ); with an DatabaseDomain object for $wiki instead of wfWikiId(). I'm not really sure how this is happening since lazyPush() has the exact same check as push() does. Can you figure out which job is causing this? Maybe then we can trace it back to the job object creation and figure out what's going wrong

mwjames added a comment.Sep 23 2017, 5:58 AM

You know how to mark bugs as release blockers, so if there's a regression you've found and want to see it fixed, mark it as a release blocker. :)

I know, but the last time ... anyway my experience on that issue has not an encouraging track record, so I only do the minimum now.

ith an DatabaseDomain object for $wiki instead of wfWikiId(). I'm not really sure how this is happening since lazyPush() has the exact same check as push() does.

Test instance is maintained with $wgDBname = "mw-master"; where DatabaseDomain::encode will encode - as ?h, it is reasonable to argue that the decode is messing up - given the "... JobQueueGroup.php: Domain 'mw?hmaster' is not recognized. ..." message.

I didn't look any further.

an you figure out which job is causing this?

A quick look in logs shows:

  • HTMLCacheUpdateJob, LinksUpdate, RecentChangesUpdateJob
2017-09-23 05:43:17 TAURUS mw-master: [f4ea3042ed26cd211d3e3154] /mw-master/index.php?title=Lorem_ipsum-1eab&action=submit   LogicException from line 138 of ...\mw-master\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\mw-master\includes\deferred\DeferredUpdates.php(252): JobQueueGroup->push(JobSpecification)
#1 ...\mw-master\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(LinksUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#2 ...\mw-master\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#3 ...\mw-master\includes\MediaWiki.php(895): DeferredUpdates::doUpdates(string)
#4 ...\mw-master\includes\MediaWiki.php(719): MediaWiki->restInPeace(string, boolean)
#5 ...\mw-master\includes\MediaWiki.php(740): MediaWiki->{closure}()
#6 ...\mw-master\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#7 ...\mw-master\index.php(43): MediaWiki->run()
#8 {main}
2017-09-23 05:43:18 TAURUS mw-master: [f4ea3042ed26cd211d3e3154] /mw-master/index.php?title=Lorem_ipsum-1eab&action=submit   LogicException from line 138 of ...\mw-master\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\mw-master\includes\jobqueue\JobQueueGroup.php(220): JobQueueGroup->push(array)
#1 ...\mw-master\includes\deferred\MWCallableUpdate.php(30): JobQueueGroup::pushLazyJobs()
#2 ...\mw-master\includes\deferred\DeferredUpdates.php(257): MWCallableUpdate->doUpdate()
#3 ...\mw-master\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#4 ...\mw-master\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#5 ...\mw-master\includes\MediaWiki.php(895): DeferredUpdates::doUpdates(string)
#6 ...\mw-master\includes\MediaWiki.php(719): MediaWiki->restInPeace(string, boolean)
#7 ...\mw-master\includes\MediaWiki.php(740): MediaWiki->{closure}()
#8 ...\mw-master\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#9 ...\mw-master\index.php(43): MediaWiki->run()
#10 {main}
2017-09-23 05:43:19 TAURUS mw-master: [f4ea3042ed26cd211d3e3154] /mw-master/index.php?title=Lorem_ipsum-1eab&action=submit   LogicException from line 138 of ...\mw-master\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\mw-master\includes\jobqueue\JobQueueGroup.php(220): JobQueueGroup->push(array)
#1 ...\mw-master\includes\deferred\MWCallableUpdate.php(30): JobQueueGroup::pushLazyJobs()
#2 ...\mw-master\includes\deferred\DeferredUpdates.php(257): MWCallableUpdate->doUpdate()
#3 ...\mw-master\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#4 ...\mw-master\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#5 ...\mw-master\includes\jobqueue\JobRunner.php(301): DeferredUpdates::doUpdates()
#6 ...\mw-master\includes\jobqueue\JobRunner.php(193): JobRunner->executeJob(HTMLCacheUpdateJob, Wikimedia\Rdbms\LBFactorySimple, BufferingStatsdDataFactory, integer)
#7 ...\mw-master\includes\MediaWiki.php(962): JobRunner->run(array)
#8 ...\mw-master\includes\MediaWiki.php(948): MediaWiki->triggerSyncJobs(integer, MediaWiki\Logger\LegacyLogger)
#9 ...\mw-master\includes\MediaWiki.php(900): MediaWiki->triggerJobs()
#10 ...\mw-master\includes\MediaWiki.php(719): MediaWiki->restInPeace(string, boolean)
#11 ...\mw-master\includes\MediaWiki.php(740): MediaWiki->{closure}()
#12 ...\mw-master\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#13 ...\mw-master\index.php(43): MediaWiki->run()
#14 {main}

#10 {main}
2017-09-23 05:45:28 TAURUS mw-master: [f4ea3042ed26cd211d3e3154] /mw-master/index.php?title=Lorem_ipsum-1eab&action=submit   LogicException from line 138 of ...\mw-master\includes\jobqueue\JobQueueGroup.php: Domain 'mw?hmaster' is not recognized.
#0 ...\mw-master\includes\jobqueue\JobQueueGroup.php(220): JobQueueGroup->push(array)
#1 ...\mw-master\includes\deferred\MWCallableUpdate.php(30): JobQueueGroup::pushLazyJobs()
#2 ...\mw-master\includes\deferred\DeferredUpdates.php(257): MWCallableUpdate->doUpdate()
#3 ...\mw-master\includes\deferred\DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactorySimple, string, integer)
#4 ...\mw-master\includes\deferred\DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#5 ...\mw-master\includes\jobqueue\JobRunner.php(301): DeferredUpdates::doUpdates()
#6 ...\mw-master\includes\jobqueue\JobRunner.php(193): JobRunner->executeJob(RecentChangesUpdateJob, Wikimedia\Rdbms\LBFactorySimple, BufferingStatsdDataFactory, integer)
#7 ...\mw-master\includes\MediaWiki.php(962): JobRunner->run(array)
#8 ...\mw-master\includes\MediaWiki.php(948): MediaWiki->triggerSyncJobs(integer, MediaWiki\Logger\LegacyLogger)
#9 ...\mw-master\includes\MediaWiki.php(900): MediaWiki->triggerJobs()
#10 ...\mw-master\includes\MediaWiki.php(719): MediaWiki->restInPeace(string, boolean)
#11 ...\mw-master\includes\MediaWiki.php(740): MediaWiki->{closure}()
#12 ...\mw-master\includes\MediaWiki.php(553): MediaWiki->doPostOutputShutdown(string)
#13 ...\mw-master\index.php(43): MediaWiki->run()
#14 {main}
gerritbot subscribed.Sep 25 2017, 10:37 AM

Change 380471 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Clean up wiki ID and DB domain ID handling

https://gerrit.wikimedia.org/r/380471

gerritbot added a project: Patch-For-Review.Sep 25 2017, 10:37 AM
mwjames added a comment.Sep 25 2017, 1:32 PM

https://gerrit.wikimedia.org/r/380471

A quick checkout of the PR confirms that the system no longer produces above listed exceptions.

Krinkle renamed this task from LogicException from line 136 of ... JobQueueGroup.php: Domain ... recognized. to Fix "LogicException from JobQueueGroup.php: Domain ... not recognized.".Sep 25 2017, 5:56 PM
Krinkle added a project: MW-1.30-release.
gerritbot added a comment.Oct 1 2017, 8:50 PM

Change 380471 merged by jenkins-bot:
[mediawiki/core@master] Clean up wiki ID and DB domain ID handling

https://gerrit.wikimedia.org/r/380471

gerritbot added a comment.Oct 1 2017, 9:12 PM

Change 381703 had a related patch set uploaded (by Legoktm; owner: Aaron Schulz):
[mediawiki/core@REL1_30] Clean up wiki ID and DB domain ID handling

https://gerrit.wikimedia.org/r/381703

gerritbot added a comment.Oct 1 2017, 9:35 PM

Change 381703 merged by jenkins-bot:
[mediawiki/core@REL1_30] Clean up wiki ID and DB domain ID handling

https://gerrit.wikimedia.org/r/381703

Legoktm closed this task as Resolved.Oct 1 2017, 9:48 PM
Legoktm assigned this task to aaron.

Merged into master and REL1_30.

ReleaseTaggerBot added projects: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release-notes.Oct 2 2017, 11:54 PM
Tgr mentioned this in T385313: "LogicException: Domain <wikiid> is not recognized." in CentralAuth.Jan 31 2025, 8:09 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2025, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits